Problem/Motivation

BrowserTestBase lacks a public static $modules = []; forcing implementations to write every time the docs instead of simply {@inheritdoc}.

Proposed resolution

Add public static $modules = []; in BrowserTestBase as KernelTestBase has.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#7 interdiff.txt600 bytesclaudiu.cristea
#7 2801883-7.patch808 bytesclaudiu.cristea
#5 interdiff.txt401 bytesclaudiu.cristea
#5 2801883-5.patch808 bytesclaudiu.cristea
#2 2801883-2.patch805 bytesclaudiu.cristea
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

claudiu.cristea created an issue. See original summary.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Version: 8.3.x-dev » 8.2.x-dev
FileSize
2801883-2.patch805 bytes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Title: Add an empty $module property in BTB » Add an empty $module property in BrowserTestBase
Status: Active » Needs review
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Title: Add an empty $module property in BrowserTestBase » Add an empty $modules property in BrowserTestBase
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
FileSize
2801883-5.patch808 bytes
interdiff.txt401 bytes

Improved @var in docs.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
Issue tags: +DX (Developer Experience)
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon commented
FileSize
2801883-7.patch808 bytes
interdiff.txt600 bytes

According to https://www.drupal.org/coding-standards/docs#order, @var should precede @see.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented
Status: Needs review » Reviewed & tested by the community

Nice finding!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

I think this change is really just a docs change and therefore eligible for 8.2.x.

Committed and pushed 41cab62 to 8.3.x and 0204b8e to 8.2.x. Thanks!

  • alexpott committed 41cab62 on 8.3.x 
    Issue #2801883 by claudiu.cristea: Add an empty $modules property in...

  • alexpott committed 0204b8e on 8.2.x 
    Issue #2801883 by claudiu.cristea: Add an empty $modules property in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.