Problem/Motivation

Both Configuration Provider and Features provide ServiceProvider classes implementing ServiceModifierInterface::alter() to swap out the class of the config.installer service.

Because Features is later alphabetically, by default its implementation overwrites that of Configuration Provider.

Proposed resolution

Explicitly set module weight on install to a high value (100).

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#20 2800839.diff8.09 KBtrackleft2

Issue fork config_provider-2800839

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nedjo created an issue. See original summary.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Issue summary: View changes

  • nedjo committed d2d270a on 8.x-1.x 
    Issue #2800839 by nedjo: Address conflict with Features over config....
nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Status: Closed (fixed) » Active

In #2625310: Address conflict with other modules over config.installer class the approach in features was changed to use a decorator. We now need to roll back the change made previously in this issue and instead switch to the same decorator pattern.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Version: 8.x-1.x-dev » 3.0.x-dev

trackleft2 opened merge request !16

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

Added a PHPUnit test, however it requires a composer.json to add dev dependencies (features.)

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Active » Needs review
trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

The two composer jobs are failing due to the lack of a Drupal 11 compatible version of features.
Personally, I think having the ability to test interoperability between this module and features is valuable, however if features doesn't create a compatible release, we'll be stuck with broken jobs.

We could consider just copying the parts of features we need to test into our test module.

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs review » Needs work

trackleft2 opened merge request !19

trackleft2 changed the visibility of the branch 3.0.x to hidden.

joegraduate’s picture

joegraduate
Primary language English
Location Arizona, USA
commented
anicho01’s picture

anicho01 commented

I know this was just flagged, but we're having a conflict with Features over config provider 3.0.0-alpha3

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented

Hey there @anicho01 I've updated the merge requests, however it is difficult to test without a Drupal 11 compatible version of features...

mprell’s picture

mprell commented

@trackleft2 this issue occurs (and I assume can be tested) when using the Features D11 compatibility fork

https://git.drupalcode.org/issue/features-3447460

trackleft2 closed merge request !16

trackleft2’s picture

trackleft2
Primary language English
Location Tucson, AZ 🇺🇸
commented
Status: Needs work » Needs review
StatusFileSize
new 2800839.diff8.09 KB

Features has a Drupal 11 release., so I've updated the merge request. Adding a static patch for your testing convenience. If the patch works for you, please mark as Reviewed and Tested by the Community.

mprell’s picture

mprell commented

Unfortunately I haven't been able to test this patch yet because alpha3 causes a separate regression: PreExistingConfigException during profile installation for any module shipping config/install/ files that overlap with dependency config. This affects all Features-generated modules in our distribution.

I've filed a new issue for this: https://www.drupal.org/project/config_provider/issues/3572966

Until that's resolved, I can't get far enough through site-install to test the decorator stacking behavior this patch addresses.