Closed (fixed)
Project:
Select Icons
Version:
8.x-1.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
15 Sep 2016 at 01:12 UTC
Updated:
30 Oct 2016 at 20:44 UTC
Jump to comment: Most recent, Most recent file

Comments
Comment #2
matsbla commentedComment #6
matsbla commentedTrying one more time.
Comment #7
matsbla commentedComment #8
matsbla commentedComment #12
developmenticon commentedHi matsbla,
I am attaching a new patch to fix flag icon position and long country names. Please review it.
Thanks,
Himanshu
Comment #16
vlad.dancerThis looks very strange. Everywhere we are using 'px'. We should follow single measure unit for now.
Also please add an interdiff, because it's very difficult to do a review.
Comment #17
matsbla commentedNot needed.
Please also add:
Styling for RTL languages needs to be fixed.
Comment #18
developmenticon commentedHi matsbla,
I am attaching a updated version of patch and also rtl issue fixed Please review it.
Thanks,
Himanshu
Comment #19
matsbla commentedStill not working for RTL languages.

+ width: auto !important;Okay good, but maybe also:
+ min-width: 200px;Comment #20
matsbla commentedAlso needs
+ text-align: left;for LTR and
+ text-align: right;for RTL
If not the text in top is set to center:

Comment #21
developmenticon commentedUpdated patch with JS to recalculate country drop down for RTL-languages
Comment #25
developmenticon commentedDropdown box margin removed for rtl, attached updated patch.
Comment #29
vlad.dancerLooks good for me. Tested on mobile and also with left aligned languages.
Thanks. Lets wait for matsbla response.
Comment #30
vlad.dancerOh, by the way, @developmenticon, replace tabs with whitespaces.
Comment #34
matsbla commented@vlad.dancer:
Like this?
Comment #35
vlad.dancerYea, it is. @matsbla so are we ready to commit this changes?
Comment #39
vlad.dancerComment #40
vlad.dancerShould be part of flags module, not of this one.
Various indent. Please, fix this.
Comment #41
vlad.dancerFixed indent, replaced tabs with spaces, removed .flag from css classes.
Comment #42
vlad.dancerComment #43
matsbla commentedTested and works good, just a small detail:
+/* Style flag position */"Style icon position"
Comment #45
vlad.dancerComment #46
vlad.dancer