hook_entity_insert() and hook_entity_update() are confusing

I think hook_entity_insert() still make sense. There are specific tasks that are applying only to entity insertion.

>I think hook_entity_insert() still make sense. There are specific tasks that are applying only to entity insertion.

Well for that postSave has the $update boolean. I'm +1 for adding postSave as it helps with consistency also, I'm not so sure about deprecating insert/update. Seems to be a too large change to do between to minor versions to me (for everyone who wants to be a good citizen and follow deprecations).

Note: slightly related: #1729812: Separate storage operations from reactions

Should we include some conversions, to see how that looks?

The deprecation message isn't following the standard yet :)

I guess the only argument against this is the long-term goal of removing hooks completely in favor of events? So adding new hooks is going a bit against that. Personally, I'm in no hurry to go there, though :)

+++ b/core/modules/content_moderation/content_moderation.module
@@ -91,21 +91,16 @@ function content_moderation_entity_presave(EntityInterface $entity) {
+  if ($entity->isNew()) {
+    return $entity_operation->entityInsert($entity);
+  }
+  else {
+    return $entity_operation->entityUpdate($entity);

this doesn't work AFAIK, isNew() is already updated at this point and it is no longer new. That's why ::postSave() has an $update argument.

This issue is a dupe of #2221347: Add hook_entity_postsave hook. Although this issue has progress...