Closed (fixed)
Project:
Drupal core
Version:
8.2.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Sep 2016 at 12:02 UTC
Updated:
7 Oct 2016 at 10:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
naveenvalechaIt should points to https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Field%21F...
Comment #3
sneha_surve commentedComment #4
joachim commentedComment #5
naveenvalechaLinked it directly using @link tag. Is there any alternate/better way to link it ?
Comment #6
joachim commentedI don't think that's the best way.
Adding the class name is better: FieldItemInterface::delete(). Though probably needs to be the fully qualified classname, I'm not sure.
Comment #7
naveenvalechaI have pinged the Jennifer to points us what's the better way to handle this as I was also not sure whether that was correct.
Comment #8
shashikant_chauhan commentedAdding patch
Comment #9
daffie commentedI think we can change this to: "Invoking the method \Drupal\Core\Field\FieldItemListInterface::delete() for each field on the entity. A file field type might use this method to delete uploaded files from the filesystem."
Comment #10
shashikant_chauhan commented@daffie, updated the patch as per your suggestion.
Comment #11
joachim commentedGetting there, but it needs to wrap to 80 chars.
Also, we possibly don't need the @link at all, come to think of it. IIRC a fully-qualified method will automatically link.
Comment #12
hardikpandya commentedAdding changes as per suggestion #11
Comment #13
daffie commentedTwo remarks:
These changes do not belong in this issue.
This line has an added space at of the line. Please remove it.
Comment #14
hardikpandya commentedChanges done as suggested at #13
Comment #15
hardikpandya commentedComment #16
daffie commentedIt looks good to me.
For me it is RTBC.
For the committer: Please ignore the first hunk of the patch with the unnecessary removal of a empty line.
Comment #17
alexpottCommitted and pushed 4338fa0 to 8.3.x and 719c20a to 8.2.x. Thanks!
As a docs patch this is rc eligible and therefore can be committed to 8.2.x
This is not correct and is totally out-of-scope for this issue. Reverted on commit.