CommentFileSizeAuthor
#2 2798523-2.patch722 bytesnaveenvalecha

Comments

naveenvalecha created an issue. See original summary.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Parent issue: #306662: Add redirect option to site-wide contact forms »
StatusFileSize
new 2798523-2.patch722 bytes
joachim’s picture

joachim commented
Title: Add missing param to ContactFormEditForm constructor » missing @param in ContactFormEditForm constructor
Version: 8.2.x-dev » 8.3.x-dev
Component: contact.module » documentation
Category: Task » Bug report
Priority: Minor » Normal
Status: Active » Reviewed & tested by the community
Issue tags: -Documentation, -Quickfix

Errors in docs are a bug.

Patch looks good to me.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +rc eligible

Committed and pushed f39d8fb to 8.3.x and ffd6478 to 8.2.x. Thanks!

Since this is documentation it is rc eligible. In general I wish we were working towards enabling the coding standard to check this instead of one-off patches like this. Issues exist! But I'm committing this since this was added in a change that will be released in 8.2.0.

  • alexpott committed f39d8fb on 8.3.x 
    Issue #2798523 by naveenvalecha: missing @param in ContactFormEditForm...

  • alexpott committed ffd6478 on 8.2.x 
    Issue #2798523 by naveenvalecha: missing @param in ContactFormEditForm...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.