It worked in Aegir 2.x before, but got somehow lost in Aegir 3.x

CommentFileSizeAuthor
0001-Restore-client_email-option-support-on-hostmaster-in.patch789 bytesmemtkmcc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

memtkmcc created an issue. See original summary.

helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions commented

Hmm, not sure why that would be needed. 'client_email' is passed as parameter to the provision-install command a few lines lower. Could we then remove that one?

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

Hmm.. but it just never worked for us without that patch after moving to 3.x.

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

Without this patch Aegir always forced this.email@is.invalid for us.

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

Also, I don't understand why it is passed to provision-install separately, and not written in the provision-save step above.

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

So yeah, it seems redundant, but also weird how it got this.email@is.invalid for us without that option added to the array for provision-save.

colan’s picture

colan
he/him
Primary language English
Location Toronto 🇨🇦
CreditAttribution: colan at Colan Schwartz Consulting commented

Just to confirm the problem, I ran into this when installing Aegir manually before I started using the Debian package:

drush hostmaster-install --client_name=$SUDO_USER --client_email=$SUDO_USER@example.com --http_service_type=nginx --working-copy

The --client_email never had any effect.

memtkmcc’s picture

memtkmcc CreditAttribution: memtkmcc at Omega8.cc commented

Yeah, I have some logs from our tests archived, and it looked like this:

Error validating client email `root`. Please check your user account email. To allow the site installation to proceed, the email [warning]
`this.email@is.invalid` has been used instead. Please use the `login` link to change the site admin email to a proper valid address.
(...)
Sent welcome mail to this.email@is.invalid
helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for Aegir Cooperative commented

Added to https://github.com/aegir-project/provision/pull/6 to help test .. (PS: Travis is not fully functional yet.)

  • helmo committed 92d0221 on 7.x-3.x authored by memtkmcc 
    Issue #2798149 by memtkmcc: Restore client_email option support on...
helmo’s picture

helmo CreditAttribution: helmo as a volunteer and at Initfour websolutions for Aegir Cooperative commented
Status: Needs review » Fixed

merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.