We are using this patch in BOA for years, and it allows to greatly improve UX, because instead of educating users to always Verify before trying to run Clone task on a site, or check if aliases have not been messed up, it does it for the user, on the fly, and then runs verify via frontend on both original and cloned site to fix this very old problem with aliases not re-attached properly: https://www.drupal.org/node/1004526#comment-9450423

CommentFileSizeAuthor
0001-Improve-Clone-task-reliability-with-extra-sub-tasks-.patch2.8 KBmemtkmcc

Comments

memtkmcc created an issue. See original summary.

helmo’s picture

helmo commented

Added to https://github.com/aegir-project/provision/pull/6 to help test .. (PS: Travis is not fully functional yet.)

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented

That seems like a lot of 'sleep'. Looks like it might add 5 seconds 4 times?

Am I nitpicking? maybe 3 seconds is enough?

memtkmcc’s picture

memtkmcc commented

We have tried 1-9 seconds and found that 5 was the best to avoid issues, load spikes etc. while absolutely minimal to make any useful impact. It is a very low price, when compared to issues caused by race conditions and load spikes.

jon pugh’s picture

jon pugh
he/him
Primary language English
Location Newburgh, NY
commented

Sounds good to me, I knew I was splitting hairs there. :)

I am working on adding tests to ensure clones are covered: https://github.com/aegir-project/tests/pull/11

For the future: What is it about the verify task that is needed to be run? Perhaps we can save some cycles by only calling the parts of verify that are needed?

  • helmo committed 3679172 on 7.x-3.x authored by memtkmcc 
    Issue #2798143 by memtkmcc: Improve Clone task reliability with extra...
helmo’s picture

helmo commented
Status: Needs review » Fixed

merged

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.