Failing test with stable version string

Is there a way to adapt our tests to not fail in that weird way?

I thought I fixed this in #2614824: Tests fail when version constant is stable - ho hum.

@alexpott, @catch, @effulgentsia, @cilefen, and I discussed this issue today and agreed it is a major bug. It is not critical because the test failure only disrupts core when HEAD is on a tagged version constant instead of a dev version constant -- normally only for a few seconds each month -- and the release managers already are aware of the issue.

Moving to the Node component since that is where the test lives.

NodeTypeTranslationTest was moved to be a functional test in #2770921: Feb 21st: Convert chunk of WTB to BTB by just moving classes, changing use statements adding traits

It still has the same problem. Removing -dev from \Drupal::VERSION results in a failed test:

There was 1 error:

1) Drupal\Tests\node\Functional\NodeTypeTranslationTest::testNodeTypeTitleLabelTranslation
Behat\Mink\Exception\ElementNotFoundException: Button with id|name|label|value "Save and continue" not found.

/Users/paul/pj2/drupal/core/tests/Drupal/Tests/WebAssert.php:76
/Users/paul/pj2/drupal/core/tests/Drupal/Tests/BrowserTestBase.php:807
/Users/paul/pj2/drupal/core/tests/Drupal/Tests/BrowserTestBase.php:940
/Users/paul/pj2/drupal/core/modules/node/tests/src/Functional/NodeTypeTranslationTest.php:153

FAILURES!
Tests: 1, Assertions: 9, Errors: 1.

That's because the user interface is in what looks like French, even though only Spanish and English are installed on my site. The line in question in the test is:

    // Add an e-mail field.
    $this->drupalPostForm("admin/structure/types/manage/$type/fields/add-field", ['new_storage_type' => 'email', 'label' => 'Email', 'field_name' => 'email'], 'Save and continue');

The submit button is unavailable because it says 'Enregistrer et continuer' when \Drupal::VERSION does not include -dev.

Change \Drupal::VERSION to include -dev and we see this:

This is all local testing on a dev site.

It matters what the '-dev' string is. Unfortunately, it's pretty hard to search all of core for 'dev' and get useful results.

This will be fixed by #2955869: Fix multilingual install on Drupal dev version for CLI utilities as that addresses the root cause of the problem - ie. different behaviour in the installer depending on the version string. Postponing on that issue. Not marking closed because the issue still exists until that is fixed.

If the patch attached is green we can close this.

Yay - this is no longer an issue.