Problem/Motivation

Block place module is missing full stop in hook_help().

Proposed resolution

Add full stop to hook_help text string in block place module

Remaining tasks

User interface changes

Text will be one unit longer

before

after

API changes

Data model changes

Original report by shashikant_chauhan

For block place module in hook_help() full stop is missing.

'Block placement is specific to each theme on your site. This module allows you to place blocks in the context of your content pages'

CommentFileSizeAuthor
#9 after-patch.png49.5 KBshashikant_chauhan
#9 before-patch.png50.21 KBshashikant_chauhan
#3 2795539-3.patch1.09 KBshashwat purav

Comments

shashikant_chauhan created an issue. See original summary.

shashwat purav’s picture

shashwat purav commented
Assigned: Unassigned » shashwat purav
shashwat purav’s picture

shashwat purav commented
Assigned: shashwat purav » Unassigned
Status: Active » Needs review
StatusFileSize
new 2795539-3.patch1.09 KB

Added patch. Punctuation issue is resolved.

ricardoamaro’s picture

ricardoamaro commented
Status: Needs review » Reviewed & tested by the community 
  • +++ b/core/modules/block_place/block_place.module
@@ -17,7 +17,7 @@ function block_place_help($route_name, RouteMatchInterface $route_match) {
-      $output .= '<p>' . t('Block placement is specific to each theme on your site. This module allows you to place blocks in the context of your content pages') . '</p>';

    Looks good.

    • Lund’s picture

    Lund commented

    Looks fine to me, I did'nt really take it for a spin as it is quite obvious what it do and what it affects.

    sutharsan’s picture

    sutharsan commented
    Issue tags: +Needs issue summary update

    Please use the issue summary template, that makes issue summaries better readable and more complete. https://www.drupal.org/issue-summaries

    sutharsan’s picture

    sutharsan commented
    Status: Reviewed & tested by the community » Needs work

    @ricardoamaro, pasting a part of the patch, does not add real value. But you could add a screenshot to demonstrate your "Looks good."

    Lund’s picture

    Lund commented
    Issue summary: View changes
    shashikant_chauhan’s picture

    shashikant_chauhan commented
    StatusFileSize
    new before-patch.png50.21 KB
    new after-patch.png49.5 KB

    adding screenshot.

    kostask’s picture

    kostask commented
    Status: Needs work » Reviewed & tested by the community

    Patch looks good, the screenshots demonstrate it works and so did some manual testing.

    yesct’s picture

    yesct commented
    Issue summary: View changes
    alexpott’s picture

    alexpott
    he/they
    Primary language English
    Location 🇪🇺🌍
    commented
    Status: Reviewed & tested by the community » Fixed

    Committed and pushed a491c49 to 8.3.x and d3bb77b to 8.2.x. Thanks!

    As the module is experimental this is eligible for 8.2.x

    • alexpott committed a491c49 on 8.3.x 
      Issue #2795539 by Shashwat Purav, shashikant_chauhan: Punctuation issue...

    • alexpott committed d3bb77b on 8.2.x 
      Issue #2795539 by Shashwat Purav, shashikant_chauhan: Punctuation issue...

    Status: Fixed » Closed (fixed)

    Automatically closed - issue fixed for 2 weeks with no activity.