WTB to BTB, add getRawContent() in BTB

Some of these tests already have patches.

AddFeedTest - #2757023: Convert all aggregator web tests to BrowserTestBase
ManageDisplayTest - #2794347: Convert web tests to browser tests for field_ui module

I didn't check all of them.

Ok. And a scope I assume is something like "tests using getRawContent()" so the relevant parts of the other patches should be included in a patch for this issue.

What about adding the function to BTB for #2794285: [meta] Add backwards compatibility layer to browsertestbase to ease conversion from webtestcase ? xjm mentioned that before but I don't think it was ever responded to. It seems like it would be a lot faster than converting all the tests manually.

  /**
   * Retrieves the raw content from the current page.
   */
  protected function getRawContent() {
    return $this->getSession()->getPage()->getContent();
  }

First test pass. Unassign issue.

Please see @klausi's comment from #2757023-24: Convert all aggregator web tests to BrowserTestBase:

The original getRawContent() method is in AssertContentTrait, so I vote to implement it in AssertLegacyTrait. We should open an issue for that and add test coverage for it to BrowserTestBaseTest.

Move getRawContent() to AssertLegacyTrait and add deprecated message.

Still have to do:
- Discuss if this stay in assertLegacyTrait
- Discuss if we should add a change record and a @trigger.error()
- Add test coverage in BrowserTestBaseTest

+++ b/core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php
@@ -718,4 +718,14 @@ protected function buildXPathQuery($xpath, array $args = []) {
+   * @deprecated in Drupal 8.4.0 and will be removed before Drupal 9.0.0.
+   *   Use $this->getSession()->getPage()->getContent() instead.

The first line should be "@deprecated Scheduled for removal in Drupal 9.0.0." same as on the other methods here.

• Added trigger_error
• Match @deprecated with the rest of the file.

Thanks, now we need test coverage in BrowserTestBaseTest.

Added a test.

+++ b/core/tests/Drupal/FunctionalTests/BrowserTestBaseTest.php
@@ -232,4 +232,12 @@ public function testInstall() {
+  public function testRawContent() {
+    $this->drupalGet('test-json');
+    $this->assertEquals('{"some":"data"}', $this->getRawContent());
+  }

I think it is not necessary to add a whole new test method just to call getRawContent(). We can just add a line to testGoTo() like $this->assertSame($this->getSession()->getPage()->getContent(), $this->getRawContent());

That makes sure that the method exists and returns the expected thing without knowing anything about the content.

I have added your suggested assert to testLegacyTextAsserts() to keep legacy tests separate.

Right, testLegacyTextAsserts() also works for me.

+++ b/core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php
@@ -718,4 +718,15 @@ protected function buildXPathQuery($xpath, array $args = []) {
+   * @deprecated Scheduled for removal in Drupal 9.0.0.
+   *   Use $this->getSession()->getPage()->getContent() instead.
+   */
+  protected function getRawContent() {
+    @trigger_error('AssertLegacyTrait::getRawContent() is scheduled for removal in Drupal 9.0.0. Use $this->assertSession()->buildXPathQuery() instead.', E_USER_DEPRECATED);

message is wrong, this should say the same as the doc comment.

That does not seem to follow the guidelines: https://www.drupal.org/core/deprecation

Sorry, I meant that "$this->assertSession()->buildXPathQuery()" is wrong in the message. This should be "$this->getSession()->getPage()->getContent()".

I don't know where that came from!
copy_paste--

Looks ready. We need it :)

Committed and pushed 1e56b1f to 8.4.x and e425b10 to 8.3.x. Thanks!