Problem/Motivation

Psy Shell v0.7.0 (PHP 7.0.7 — cli) by Justin Hileman
>>> sys_get_temp_dir()
=> "/var/tmp/"

This made working on #2791163: Random automatic testing failures on SQLite with PHP 5.5 tricky.

Proposed resolution

Do a trim in file_directory_os_temp() to ensure consistency.

Remaining tasks

User interface changes

None

API changes

None

Data model changes

None

CommentFileSizeAuthor
#2 2794207-2.patch546 bytesalexpott

Comments

alexpott created an issue. See original summary.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 2794207-2.patch546 bytes

I tried to add a test but you can't call ini_set on upload_tmp_dir so it is just not possible.

daffie’s picture

daffie commented
Status: Needs review » Reviewed & tested by the community

Looks good to me.

I do not see how we can add testing for this. We do not know when the trailing directory separator will be added.

For me this is RTBC.

  • catch committed b01e462 on 8.1.x 
    Issue #2794207 by alexpott: sys_get_temp_dir() can return a path with a...

  • catch committed 5fd082b on 8.2.x 
    Issue #2794207 by alexpott: sys_get_temp_dir() can return a path with a...

  • catch committed ed8ceb7 on 8.3.x 
    Issue #2794207 by alexpott: sys_get_temp_dir() can return a path with a...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to all three 8.x branches, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.