Between new code and eslint updates, some errors sneaked in the codebase:

Problems "fixed":

drupal/core/misc/tabledrag.js
  505:9  error  Expected a 'break' statement before 'case'  no-fallthrough
  513:9  error  Expected a 'break' statement before 'case'  no-fallthrough
  556:9  error  Expected a 'break' statement before 'case'  no-fallthrough
  564:9  error  Expected a 'break' statement before 'case'  no-fallthrough
  631:9  error  Expected a 'break' statement before 'case'  no-fallthrough
  633:9  error  Expected a 'break' statement before 'case'  no-fallthrough
  635:9  error  Expected a 'break' statement before 'case'  no-fallthrough

drupal/core/modules/outside_in/js/outside_in.js
  128:22  error  Multiple spaces found before 'Drupal'                     no-multi-spaces
  145:13  error  Expected indentation of 10 space characters but found 12  indent

✖ 9 problems (9 errors, 0 warnings)

Did not want to touch tabledrag code so I just turned off the checks for the 2 problematic switches.

CommentFileSizeAuthor
core-js-eslint-fix.patch1.94 KBnod_

Comments

nod_ created an issue. See original summary.

nod_’s picture

Issue summary: View changes
droplet’s picture

Status: Needs review » Reviewed & tested by the community

better readability with the Switch statements, so yeah that's fine.

  • xjm committed 0e9422a on 8.3.x
    Issue #2793349 by nod_, droplet: Fix eslint errors
    
xjm’s picture

Status: Reviewed & tested by the community » Fixed

I confirmed this removes all eslint errors, so this is an appropriate scope for coding standards that are already tested.

Committed 0e9422a and pushed to 8.3.x and 8.2.x. Thanks!

  • xjm committed 30ce23e on 8.2.x
    Issue #2793349 by nod_, droplet: Fix eslint errors
    
    (cherry picked from...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.