Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.OG ships with a 'group file library' default View. This View depends on fields and sorts from upload.module. If upload is not active in the install, i am seeing "notice: Undefined property: views_handler_field_broken::$definition in /Users/mw/htd/pr6og/sites/all/modules/views/includes/field.handlers.inc on line 126.". Would be nice if Views did not emit this error. The error happens pretty frequently (perhaps when the default views are scanned).
Comments
Comment #1
merlinofchaos commentedYou should probably only advertise this as a default view if all requirements are active; even with the notices cleaned up, the view will still not work.
Comment #2
moshe weitzman commentedEarl said he would work on this as time permits. We will add a new check for plugins as well.
Comment #3
merlinofchaos commentedhttp://drupal.org/cvs?commit=128999
This won't catch validator and argument default plugins, which it probably should, but I consider those fairly low risk.
Comment #4
moshe weitzman commentedThanks. I took a look at the diff. I'm not sure that throwing errors is really the right behavior for the use case I mentioned above (OG module). Each time the site rebuilds its Views these will be thrown? I was thinking of silently logging to watchdog.
Comment #5
merlinofchaos commentedActually this only happens on import. Hah! I did this wrong, didn't I? It's ok, it can be reconfigured to work both on import and for default views I think.
Comment #6
moshe weitzman commentedI'd be sad to see us release without this so I bump to critical and mark as bug since it is a regression from D5. But feel free to demote as needed.
Comment #7
merlinofchaos commentedThis still needs to be worked on, but it seemed not to be as straightforward as it was in Views 1.
Comment #8
merlinofchaos commentedTouching, just to bring this into the more recently active group. This still needs to be done, it is still a problem for modules containing views that will be broken if things they need do not exist.
Comment #9
Letharion commented@merlin
Since you didn't seem to object to moshe making this critical, I'm assigning to you as a reminder that it's important.
Comment #10
merlinofchaos commentedInterestingly, it hasn't *really* come up very much, other than for modules like og.
If someone wants to work on this, technically this is a major regression from Views 1, but it will require someone willing to write the patch to do this.
Comment #11
mustanggb commented