Replace usage of t() in plugins with $this->t()

Thanks! This looks like it should work just fine. Retesting, hopefully it was a testbot hiccup.

This will need to be done against 8.3 though.

First time attempting a reroll.

I pulled 8.3 and was able to apply the patch.
There wasn't any output, so no reroll is needed? (reading off the reroll docs)

EDIT: I am a little confused if I'm doing this right... should I re-upload the patch to test against 8.3?

t() in plugins with $this->t().

@amit.drupal Now you did it for all modules, not just for ckeditor.module. Please revert that.

Apologies, Attaching new patch

sorry wrong patch applied.

WebTestBase does not include StringTranslationTrait. I added that in order to make tests extending the WebTestBase able to use $this->t(). Also DrupalImageCaption was using Drupal\Component\Plugin\PluginBase instead of Drupal\Core\Plugin\PluginBase.

Let's see what the testbot has to say about it :)

--- a/core/modules/simpletest/src/WebTestBase.php
+++ b/core/modules/simpletest/src/WebTestBase.php

Let's not modify WebTestBase.

--- a/core/modules/ckeditor/src/Tests/CKEditorAdminTest.php
+++ b/core/modules/ckeditor/src/Tests/CKEditorAdminTest.php
…
--- a/core/modules/ckeditor/src/Tests/CKEditorStylesComboAdminTest.php
+++ b/core/modules/ckeditor/src/Tests/CKEditorStylesComboAdminTest.php
…
--- a/core/modules/ckeditor/src/Tests/CKEditorToolbarButtonTest.php
+++ b/core/modules/ckeditor/src/Tests/CKEditorToolbarButtonTest.php
…

These changes should be reverted. We should only modify actual code, not tests.

Tests can continue to use t().

Sorry for not noticing sooner!

Here it is :)

Thanks!

Committed 6a83671 and pushed to 8.3.x. Thanks!