Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Problem/Motivation
This is a follow up to #2777451: @see references not forming links in documentation. In #9 over there @alexpott suggested fixing or removing the following documentation starting at line 23 in core/lib/Drupal/Core/Database/Driver/pgsql/Schema.php
* This is collected by DatabaseConnection_pgsql->queryTableInformation(),
* by introspecting the database.
and at line 123 in core/lib/Drupal/Core/Database/Driver/mysql/Schema.php.
// @see DatabaseConnection_mysql
Proposed resolution
None yet.
Remaining tasks
Make a patch.
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Comment | File | Size | Author |
---|---|---|---|
#6 | 2791375-6.patch | 1.43 KB | shashikant_chauhan |
Comments
Comment #2
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commentedreplaced the DatabaseConnection_pgsql->queryTableInformation with \Drupal\Core\Database\Driver\pgsql\Schema::queryTableInformation(). Adding patch for it.
Comment #3
daffie CreditAttribution: daffie commentedLooks good to me.
Comment #4
xjmThanks for working on this!
There's another outdated reference in this pattern in
Schema.php
:(The last three references are in a Drupal 7 fixture and so do not need to be changed.)
Comment #5
alexpottSince we've got the @see we don't to use the fully qualified class name because it is redundant. So changing this to
Schema::queryTableInformation()
.Comment #6
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commentedadding updated patch as suggested.
Comment #7
shashikant_chauhan CreditAttribution: shashikant_chauhan as a volunteer and at Iksula commentedComment #8
daffie CreditAttribution: daffie commentedI think that this is how @xjm and @alexpott would like to have it.
Comment #9
alexpottSince this is docs it can go in both 8.3.x and 8.2.x.
Committed and pushed 178cbb9 to 8.3.x and a51cf37 to 8.2.x. Thanks!