Tests broken - fix HEAD / Demo

I ran the tests with several versions of search_api and found the commit that broke paragraphs_demo:

http://cgit.drupalcode.org/search_api/commit/?id=921b616

https://www.drupal.org/node/2612104

The tests will pass again after removing this specific change from src/Entity/Index.php in search_api.

@@ -1207,12 +1138,21 @@ public function preSave(EntityStorageInterface $storage) {
       'index_directly' => TRUE,
     );
 
-    // Remove all "locked" and "hidden" flags from all fields of the index. If
-    // they are still valid, they should be re-added by the processors.
     foreach ($this->getFields() as $field_id => $field) {
+      // Remove all "locked" and "hidden" flags from all fields of the index. If
+      // they are still valid, they should be re-added by the processors.
       $field->setIndexedLocked(FALSE);
       $field->setTypeLocked(FALSE);
       $field->setHidden(FALSE);
+
+      // Also check whether the underlying property actually (still) exists.
+      $datasource_id = $field->getDatasourceId();
+      if (!isset($properties[$datasource_id])) {
+        $properties[$datasource_id] = $this->getPropertyDefinitions($datasource_id);
+      }
+      if (!Utility::retrieveNestedProperty($properties[$datasource_id], $field->getPropertyPath())) {
+        $this->removeField($field_id);
+      }
     }

This seems to be working. :)

The config is ok I think. I was able to get the search working by doing a single import of the index config after the module was installed. The search fields are not getting imported with the rest of the search index settings during the install for some reason.

Did not mean to change that.

I've been looking in the code of search_api, as far as I've seen the problem comes when preSaving the index, in the issue @jmuzz refers they add an extra if to check if the index of the current field is valid. I think this needs to be fixed in search_api.

I don't think they knew about it. I created an issue in the search_api queue.

Added related issue. Thanks @jmuzz

Might be worth getting the tests passing even before that issue is fixed so testbot doesn't keep setting working patches to "Needs work".

yes, meanwhile we can do that.