As part of #2784443: Move off-canvas functionality from Settings tray module into drupal.dialog.ajax library so that other modules can use it we need to ensure that from an offcanvas tray you can click links that:

  1. Open a modal
  2. Open inside the offcanvas tray(reloading it).

Item 1 doesn't sound like good UX but unless we are somehow going to stop it from happening we should check that it works.

@droplet pointing out in #2786459: "Offcanvas" tray should be using the existing dialog system that if we take this approach dialog links inside the offcanvas will trigger that same listeners so it might cause problems.

Whether or not we use #2786459: "Offcanvas" tray should be using the existing dialog system is committed we should update \Drupal\Tests\outside_in\FunctionalJavascript\OffCanvasTest to ensure this works.

Comments

tedbow created an issue. See original summary.

tkoleary’s picture

@tedbow

Item 1 doesn't sound like good UX but unless we are somehow going to stop it from happening we should check that it works.

Item 1 is not a good idea and we should stop it from happening. The default behavior should be that additional dialogs re-load the tray with the new dialog in the tray.

However, if that is the case, the expectation of the user is going to be that they can get back to the previous form. this is not necessarily covered by the cancel button in the dialog because the expected behavior of that button is that the dialog (tray) is closed and they are returned to where they started. There also needs to be the ability to 'step back' to the previous dialog which would require an affordance like a back arrow or link.

tedbow’s picture

Status: Active » Fixed

\Drupal\Tests\outside_in\FunctionalJavascript\OffCanvasTest actually covers this now

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)