For consistency, 'groups path' in migrate_yaml_api implementations should be 'group path'.

Comments

hussainweb created an issue.

hussainweb’s picture

hussainweb
Primary language English
commented

I am wondering if 'groups path' makes sense. The path is supposed to contain one or more YML files. It seems awkward to call it 'group path' in that case.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

The path contains a group of files or a group of groups?

hussainweb’s picture

hussainweb
Primary language English
commented

@joelpittet, it contains one or more YML files, each of which represents a migration group. Hence, there are definitions of multiple groups in a directory.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Ok take this from a different angle: how does this work with the 'group arguments' or should that be 'groups arguments'?

hussainweb’s picture

hussainweb
Primary language English
commented

how does this work with the 'group arguments'

These are the arguments that are passed to each group. That is why it made sense.

I don't mind changing it to 'group path', and if we change it, it should be now, before there is a stable release. It is certainly more consistent. It just sounded weird in my head just as soon as I changed it and was about to create a patch.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

So the 'group arguments' are kind of like 'common arguments' for all groups or you can do it per group?

Sorry just trying to understand their meaning and 'groups path' sounds like it's meant to be possessive without the apostrophe but I could be wrong.

hussainweb’s picture

hussainweb
Primary language English
commented

@joelpittet, 'group arguments' apply to all groups. If you want to do it per group, you can as well place it inside the YML file.

And 'groups path' is not meant to be possessive. It is just a plural. Like I said earlier, it is a path where you place all the group definitions. The other 'path' key we have would have been 'migrations path' but since that is the main key you need to return, I made it 'path' for simplicity.