Closed (outdated)
Project:
Social Auth
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
23 Aug 2016 at 12:02 UTC
Updated:
29 Sep 2017 at 03:23 UTC
Jump to comment: Most recent
Comments
Comment #2
gvsoThe code is at https://github.com/drupalsocialinitiative/social_auth_facebook.
I think I haven't created a project in Drupal mainly because I do not still have access to create full projects (application can be found at https://www.drupal.org/node/2765445) and because I would like to have some functionality, which is currently specific to social_auth_facebook, in the social_auth code (e.g. saving users' profile pictures).
Comment #3
toemaz commentedThanks for the quick reply gvso. Great to see the code is out there already.
From the readme I noticed that the authentication is through matching the email only. Would you accept a patch to change this to matching on facebook id instead? For a background discussion why using the FB id to match, see https://www.drupal.org/node/2387073
Comment #4
gvsoI guess you have a good point there. Nonetheless, this modules was based on Simple FB Connect because @masipila told me he would maintain this module after we finished to adapt it, so changing that functionality will alter the module.
Doesn't Simple FB Connect have an API for D8? Shouldn't we have @masipila involved in this discussion?
Comment #5
swentel commented@gvso There's something I don't get, but I might be missing background information, and that's why there's a dependency on the social auth module in general. The only connection between them is that the Network plugin is picked up and that's more or less it. In my mind I would expect things like this in social auth:
- route class that generates a route based on the plugin for redirect and callback, maybe even one for settings too, although that's a little trickier of course.
- controller that based on the route is then able to call the right sub plugin to handle the things it need to do (e.g. call graph api to get fb profile and handles those thing itself etc)
Is there anything on the roadmap for this in social autho ? Because otherwise, I don't see much value in having a dependency at all.
Or is NetworkBase going to be more extended to handle all these things for instance ?
Comment #6
gvsoThis module was developed as part of a Google Summer of Code project called Social API. The initial idea behind the project was to provide a common interface for social networking functionality, so site builders can configure this piece of functionality without much differences between the components.
In the Google Summer of Code project plan, there wasn't anything about the points you gave, but I believe they are very interesting. So far, the dependency only allows the implementer to add local tasks and define a network plugin and a settings class.
The project will be extended further, so ideas and patches are more than welcome.
Comment #7
gvso