Problem/Motivation

  1. Install 8.2.x with the standard profile and enable Outside In.
  2. Visit the frontpage.
  3. Click "Edit" in the toolbar to toggle editing mode.
  4. Click on the Tools block.
  5. Click on the Search block.
  6. Try to toggle off Edit mode by clicking on Editing. You can't. It's stuck and becomes weirdly grayed out:

Workaround: force-reload the page to get out of editing mode.

Proposed resolution

TBD

Remaining tasks

TBD

User interface changes

Presumably, "Editing" does not get stuck

API changes

TBD

Data model changes

Hopefully not.

CommentFileSizeAuthor
#8 interdiff.txt522 bytesGrandmaGlassesRopeMan
#8 2787135-8.patch548 bytesGrandmaGlassesRopeMan
#7 interdiff.txt811 bytesGrandmaGlassesRopeMan
#7 2787135-7.patch530 bytesGrandmaGlassesRopeMan
#5 editissues.gif1.09 MBGrandmaGlassesRopeMan
#5 2787135-5.patch535 bytesGrandmaGlassesRopeMan
edit_stuck.png11.35 KBxjm

Comments

xjm created an issue. See original summary.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue summary: View changes
swentel’s picture

swentel commented

I can confirm this. In general, toggling between edit back and forth doesn't seem to switch nicely always. Sometimes also after saving configuration of a block. Smells like browser caching bug, but not sure, but I remember pwolanin mentioning this somewhere and proposing to add a query parameter (but I can't recall anymore on IRC/twitter/issue)

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
StatusFileSize
new 2787135-5.patch535 bytes
new editissues.gif1.09 MB

This fixes an issue where the handler for toggling edit mode would get bound multiple times preventing you from escaping edit mode.

Edit Toggle issues

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
Status: Active » Needs review
GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
StatusFileSize
new 2787135-7.patch530 bytes
new interdiff.txt811 bytes

Rerolled this based on #2786459: "Offcanvas" tray should be using the existing dialog system.

GrandmaGlassesRopeMan’s picture

GrandmaGlassesRopeMan
he/him
Primary language English
Location 🌎
commented
StatusFileSize
new 2787135-8.patch548 bytes
new interdiff.txt522 bytes

Set an appropriate key for .once().

cashwilliams’s picture

cashwilliams commented

Did not code review but tested and appears to fix the problem.

cashwilliams’s picture

cashwilliams commented
Status: Needs review » Reviewed & tested by the community

Well, maybe I should actually look at the patch first... Code reviewed.

swentel’s picture

swentel commented

yep, +1, fixes it completely. Code looks fine to me.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.2.x and 8.3.x. Thanks!

  • webchick committed ed9e669 on 8.2.x 
    Issue #2787135 by drpal, xjm, swentel, cashwilliams: Editing mode gets "...

  • webchick committed b0331c0 on 8.3.x 
    Issue #2787135 by drpal, xjm, swentel, cashwilliams: Editing mode gets "...
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Issue tags: +JavaScript

Also retroactively tagging.

xjm’s picture

xjm
she/her
Primary language English
commented

Awesome to see this fixed so fast; it was a pretty confusing bug.

I wonder if maybe we could add JS tests to ensure this doesn't regress?

nod_’s picture

nod_
Primary language French
Location Lille
commented

That fix was in #2785589: Fix js and jsdoc of outside-in module too.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

tedbow’s picture

tedbow
he/him
Primary language English
Location Ithaca, NY, USA
commented
Component: outside_in.module » settings_tray.module

Changing to new settings_tray.module component. @drpal thanks for script help! :)