I have a weird issue. The soembed filter was not working. After some debugging I found that $providers was not being passed from the include file to soembed_filter_embed().
It seems like a good idea to wrap a function around the $providers array. This will prevent any scoping issues caused while including files. Maybe it's even better to add the function to the .module file, but this is a start.
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | soembed-scoping_issue_include_file-2783373-4.patch | 6.5 KB | cleverhoods |
Comments
Comment #2
seanbPatch is attached. Please review!
Comment #3
seanbSorry, here is a patch not changing filemodes...
Comment #4
cleverhoods commentedUpdated patch
Comment #5
ki commentedIt was addressed by using `require_once` instead of `module_load_include()`. Since it is called in the function, `soembed_filter_embed()`, there should not a scoping issue.
Comment #6
ki commented