For people trying to get familiar with the code, it would really help documenting the helper functions according to the drupal coding standards.

CommentFileSizeAuthor
#7 Update-documentation-2783183-8-7.patch3.65 KBajalan065
#2 improve-docblocks-2783183-2.patch6.91 KBmarcoscano

Comments

marcoscano created an issue. See original summary.

marcoscano’s picture

marcoscano
Primary language Portuguese, Brazil
Location Barcelona, Spain
commented
Assigned: marcoscano » Unassigned
Status: Active » Needs review
StatusFileSize
new improve-docblocks-2783183-2.patch6.91 KB

This is not exhaustive, I have checked only the .module file.
(solved also some other minor CS nitpicks along the way)

Status: Needs review » Needs work

The last submitted patch, 2: improve-docblocks-2783183-2.patch, failed testing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Issue tags: +Needs reroll

patch no longer applies

ajalan065’s picture

ajalan065 commented
Assigned: Unassigned » ajalan065

I will post the new patch with improved documentation.

eugene.ilyin’s picture

eugene.ilyin commented

This comment looks strange for me

/** @var FieldDefinitionInterface $field */

ajalan065’s picture

ajalan065 commented
Assigned: ajalan065 » naveenvalecha
Status: Needs work » Needs review
Issue tags: -Needs reroll
StatusFileSize
new Update-documentation-2783183-8-7.patch3.65 KB

Here is the rerolled patch for updated documentation.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: naveenvalecha » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good we are close to the coding standards fixes :)

naveenvalecha’s picture

naveenvalecha
He/Him
commented

@ajalan065,
As mentioned you earlier in previous issue about the patch name.Consider it unless you are bypassing the drupal ci on every patch. it would be hard for us to reupload it, however its fine for me b/c I test patches on my local dev box but consider the standard approach that we are using.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Category: Feature request » Task
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.