Closed (fixed)
Project:
Drupal core
Version:
8.1.8
Component:
views.module
Priority:
Minor
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
12 Aug 2016 at 09:00 UTC
Updated:
12 Sep 2016 at 10:54 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
eloivaqueComment #3
subson commented+1
Comment #4
dawehner+1
Comment #5
catchComment #8
catchCommitted/pushed to all three 8.x branches, thanks!
Comment #10
Anonymous (not verified) commentedMaybe it is useful. The first patch corrects documentation for Views::getViewsAsOptions. The second patch refactors variables, but I'm not so sure.
I also noticed that "$view->name" is used in some contrib modules (accessibility, backbone, calendar, community_tasks, crm_core, data, efq_views, fancy_file_delete, flexiform, global_filter, google_analytics_reports, graphapi, image_replace, ip_geoloc, jqgrid, ldap, legal, merci, message_notify, message_subscribe, monitoring, nodeviewcount, pm, quicktabs, quiz, recently_read, relation, revisioning, skinr, stools, views_autocomplete_filters, views_block_filter_block, views_cache_bully, views_pdf, views_slideshow_xtra, webform, yandex_metrics).
I do not know how many of these modules is still maintaining and how serious a problem in using "$view->name" for them. Also i'm not an apologist for infinity of back compatibility. But maybe it's worth to make cheat sheet for Views with contain info about such changes.
Comment #11
dawehner@vaplas
Please open up a new issue
Comment #12
Anonymous (not verified) commentedThanks, I created a new issue.
Comment #13
dawehnerThank you!