Closed (fixed)
Project:
Social Auth
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
5 Aug 2016 at 15:06 UTC
Updated:
5 Feb 2017 at 00:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
gvsoComment #3
slivorezkaHi,
I added a method to store user's picture.
Please check it.
Thanks,
Andrew
Comment #4
gvsoThanks @slivorezka
I can't apply the patch. I get
Comment #5
slivorezkaHi @gvso
I updated the patch.
Please check it again.
Thanks,
Andrew
Comment #6
gvsoThanks @slivorezka
The event dispatcher is not being used anywhere.
This method should be generic. Why is it the id a parameter? I guess It should only receive an url or we should find a different way to generate the file name. Maybe a facebook account has the id 1234, but another Google account also has the id 1234.
Comment #7
slivorezkaHi @gvso,
I removed Event Dispatcher and implemented additional argument "provider".
Well if some accounts have the same ID it will have look like facebook_123 OR google_123
Thanks
Comment #8
gvsoComment #9
gvsoThanks again.
You have included new arguments in the construct method, but the service definition hasn't been updated in social_auth.services.yml
Maybe we can use the provider argument to create this message.
Comment #10
slivorezkaHi @gvso,
Well I did some code refactor and now must be all Ok.
Please check it again.
Thanks,
Andrew
Comment #11
gvsoComment #12
nikathoneReroll the patch on number 10 to apply on latest dev.
Comment #13
gvsoBecause of #2843056: Provide on login and create user event dispatchers, this patch can not longer be applied.
Comment #14
nikathoneAnd here is the rerolled patch.
Comment #15
nikathoneComment #16
gvsoChanges to README file have also been added here
Comment #17
nikathoneWhat changes specifically should be added to the README.txt? In the meantime I did fetch the current dev na d here is the patch.
Comment #18
nikathoneComment #20
gvsoCommitted with some changes. Thanks everyone.
We need to add this to Social Auth Example, as well as to all implementers in drupal.org
Comment #21
gvsoJust committed the changes to Social Auth Examples. Only implementers are missing, but that's not part of this issue.