Could Link module be updated to v1.4? I have multiple people requesting it here for in our sub-distro. I'm willing to help test this change.

Comments

aubjr_drupal created an issue. See original summary.

dsnopek’s picture

Sure! Please make the patch to the .make file and I'll kick off a test build on Travis. That plus some manual testing should be enough :-)

aubjr_drupal’s picture

StatusFileSize
new633 bytes

Sorry about the slow reply. Here's the patch - maybe it'll get into Panopoly 1.39. :)

dsnopek’s picture

Component: Miscellaneous » Core

Moving to Panopoly Core component for our test script

dsnopek’s picture

aubjr_drupal’s picture

Built that patch for the entire distro - not Panopoly Core. Trying again.

dsnopek’s picture

cboyden’s picture

Version: 7.x-1.37 » 7.x-1.x-dev

There is some discussion in #2666912: URL validation rejects existing valid content after upgrade to 7.x-1.4 and #2651742: always Not A Valid URL about Link's new validation layer breaking backwards compatibility. Certain links that were passed as valid in 1.3 now fail validation in 1.4. The problems include links in multilingual sites that go from one language to another, and internal links that are served by a system other than Drupal that's used on the same domain.

dsnopek’s picture

@cboyden: Thanks for the intell! This probably means we either wait until the upstream community works it out, or we could include a patch that reverts the validation change (as opposed to "fixing" it, which could mutate before being committed upstream).

cboyden’s picture

The patch in https://www.drupal.org/node/2666912#comment-11204309 does exactly that: reverts only the validation change.

dsnopek’s picture

Status: Active » Needs review
StatusFileSize
new545 bytes

Unfortunately, it looks like this problem wasn't fixed upstream. In fact, there have been no commits since the 1.4 release which was over a year ago. :-/ So, it seems like updating to 1.4 with the patch to revert the problematic feature is the best solution!

Here's a patch

EDIT: And here's a new Travis build: https://travis-ci.org/panopoly/panopoly/builds/232588906

dsnopek’s picture

Here's a new Travis build after some attempts to fix the tests:

https://travis-ci.org/panopoly/panopoly/builds/235004330

  • dsnopek committed 81b32d6 on 7.x-1.x
    Update Panopoly Core for Issue #2778617 by aubjr_drupal, dsnopek,...
dsnopek’s picture

Status: Needs review » Fixed

The tests pass, and this looks good to me. Thanks, Everyone!

  • dsnopek committed 81b32d6 on 8.x-2.x
    Update Panopoly Core for Issue #2778617 by aubjr_drupal, dsnopek,...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.