Could Link module be updated to v1.4? I have multiple people requesting it here for in our sub-distro. I'm willing to help test this change.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | panopoly_core-link-v14-2778617.patch | 545 bytes | dsnopek |
Could Link module be updated to v1.4? I have multiple people requesting it here for in our sub-distro. I'm willing to help test this change.
| Comment | File | Size | Author |
|---|---|---|---|
| #11 | panopoly_core-link-v14-2778617.patch | 545 bytes | dsnopek |
Comments
Comment #2
dsnopekSure! Please make the patch to the .make file and I'll kick off a test build on Travis. That plus some manual testing should be enough :-)
Comment #3
aubjr_drupal commentedSorry about the slow reply. Here's the patch - maybe it'll get into Panopoly 1.39. :)
Comment #4
dsnopekMoving to Panopoly Core component for our test script
Comment #5
dsnopekHere's the test build on Travis CI:
https://travis-ci.org/panopoly/panopoly/builds/150912993
Comment #6
aubjr_drupal commentedBuilt that patch for the entire distro - not Panopoly Core. Trying again.
Comment #7
dsnopekThanks! Here's the new test build:
https://travis-ci.org/panopoly/panopoly/builds/151197125
Comment #8
cboyden commentedThere is some discussion in #2666912: URL validation rejects existing valid content after upgrade to 7.x-1.4 and #2651742: always Not A Valid URL about Link's new validation layer breaking backwards compatibility. Certain links that were passed as valid in 1.3 now fail validation in 1.4. The problems include links in multilingual sites that go from one language to another, and internal links that are served by a system other than Drupal that's used on the same domain.
Comment #9
dsnopek@cboyden: Thanks for the intell! This probably means we either wait until the upstream community works it out, or we could include a patch that reverts the validation change (as opposed to "fixing" it, which could mutate before being committed upstream).
Comment #10
cboyden commentedThe patch in https://www.drupal.org/node/2666912#comment-11204309 does exactly that: reverts only the validation change.
Comment #11
dsnopekUnfortunately, it looks like this problem wasn't fixed upstream. In fact, there have been no commits since the 1.4 release which was over a year ago. :-/ So, it seems like updating to 1.4 with the patch to revert the problematic feature is the best solution!
Here's a patch
EDIT: And here's a new Travis build: https://travis-ci.org/panopoly/panopoly/builds/232588906
Comment #12
dsnopekHere's a new Travis build after some attempts to fix the tests:
https://travis-ci.org/panopoly/panopoly/builds/235004330
Comment #14
dsnopekThe tests pass, and this looks good to me. Thanks, Everyone!