Needs review
Project:
Session expire
Version:
7.x-1.0-alpha1
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
1 Aug 2016 at 19:10 UTC
Updated:
22 Sep 2017 at 21:07 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
yhurtado commentedAttaching patch version
Comment #3
shrop commentedI tested this functionality and it does work. I really like the concept. Thanks for working on this!
FILE: ...l7/web/sites/all/modules/session_expire/session_expire.drush.inc
----------------------------------------------------------------------
FOUND 12 ERRORS AFFECTING 12 LINES
----------------------------------------------------------------------
1 | ERROR | [x] Missing file doc comment
6 | ERROR | [x] Missing function doc comment, only found file
| | comment
7 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
8 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
9 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 8
10 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 8
11 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 8
12 | ERROR | [x] Array indentation error, expected 6 spaces but
| | found 8
14 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
18 | ERROR | [x] Doc comment short description must end with a full
| | stop
21 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found
| | 4
22 | ERROR | [x] Expected 1 newline at end of file; 2 found
----------------------------------------------------------------------
PHPCBF CAN FIX THE 12 MARKED SNIFF VIOLATIONS AUTOMATICALLY
----------------------------------------------------------------------
Time: 105ms; Memory: 6Mb
Comment #4
Chris CharltonThis is fine for a v1.0. The code looks fine.