Follow-up to #2743815: Fill the Alt Text of the Image File using Google Vision API

Move the helper functions to a helper service.

google_vision_edit_alt_text
google_vision_set_alt_text

CommentFileSizeAuthor
#4 2776441-4.patch8.82 KBnaveenvalecha
#2 Moved-functions-to-services-2776441-8-2.patch8.48 KBajalan065

Comments

naveenvalecha created an issue. See original summary.

ajalan065’s picture

ajalan065 commented
Assigned: ajalan065 » naveenvalecha
Status: Active » Needs review
StatusFileSize
new Moved-functions-to-services-2776441-8-2.patch8.48 KB

Here is the patch with the functions moved to services.

I have also checked the entire module for proper comments and whitespaces and added new lines to the EOF, where they were missing.

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: naveenvalecha » ajalan065
Status: Needs review » Needs work 
  1. +++ b/google_vision.services.yml
@@ -1,4 +1,7 @@
+  google_vision.fill_alt_text:

    Make the service name to be "google_vision.helper" and keep all the helper functions into it related to all detection types. 

  2. +++ b/src/AutoAltTextFill.php
@@ -0,0 +1,128 @@
+class AutoAltTextFill {

    Class name to be GoogleVisionHelper Also define the interface as well. GoogleVisionHelperInterface

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Needs work » Needs review
StatusFileSize
new 2776441-4.patch8.82 KB

Uploaded the rerolled patch with suggestions above

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Assigned: ajalan065 » Unassigned
Status: Needs review » Fixed

Committing and pushed to 8.x-1.x
While I was reviewing this I have also filed another issue #2783795: Define the Interface for GoogleVisionApi

eugene.ilyin’s picture

eugene.ilyin commented
Status: Fixed » Active

Mhh, why do we need interface GoogleVisionHelperInterface.php? Is it standard?

naveenvalecha’s picture

naveenvalecha
He/Him
commented
Status: Active » Fixed

Yup this is made to keep in mind about the #2739855: Use code from https://github.com/ThijsFeryn/google-cloud-vision-api external library when we'll implement it later(i.e. when php7 will be requirement of the drupal).We will extend the interfaces of that library in our own interface and we'll not break the constructors of our own services(api) as per the d.o. B.C. policy

‘Holy Grail’ of programming is the reuse of existing code – interfaces play an important role in this.

Feel free to reopen if you need any more clarity on it.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.