Text field summary should be filled with short text

@drunken monkey thanks for reporting.
I totally agree with you but this issue should not be filed against devel. The placeholder field values are generated by FieldItem* classes not by devel generate; in particular the value used for full text and summary is handled by TextItemBase::generateSampleValue() and the mehod does not take in account the summary setting.
I think we should move the issue to drupal core

Since the issue affect only to a specific field type ('text_with_summary' field type) I think that we could move the changes to the relative class (TextWithSummaryItem). Also probably we need test coverage for this

Adding a Reroll patch for 9.2.x, with modification to the TextItemBase::generateSampleValue() method. Also adding a test for summary filed generated through generateSampleValue() method.

Please review.

Adding the Patch for #16.

Fixed Cspell issues in #17 and resubmitting the patch.

Sorry , Uploaded the wrong patch in #18, resubmitting.

Tested #19 on 9.2, the summary now using a much shorter text after the patch
This can be moved to RTBC

Verified and tested patch #19.
Patch applied successfully and looks good to me.

Testing Steps:
# Goto: admin/modules
# Install Devel and Devel Generate modules.
# Goto: admin/config/development/generate/content
# Select a basic page and mention the node (2) numbers in the field
# Click on Generate
# Click on Content
# User should see generated 2 contents
# edit any content and check the summary field after applying the patch. (It should be in one line)

Expected Results:
# User should see short summary in one line.

Actual Results:
# Summary should not be longer like in paragraph format.

Looks good to me.
Can be a move to RTBC.

1. +++ b/core/lib/Drupal/Component/Utility/Random.php
   @@ -224,7 +224,7 @@ public function sentences($min_word_count, $capitalize = FALSE) {
        ];
   -    // cSpell:enable
   +    // cSpell:enable.
        $dictionary_flipped = array_flip($dictionary);
   

   This is out of scope, additionally it should be left without a period at the end (see other instances in core).

2. +++ b/core/lib/Drupal/Component/Utility/Random.php
   @@ -237,6 +237,9 @@ public function sentences($min_word_count, $capitalize = FALSE) {
            $words_remaining -= $sentence_length;
          }
   +      // Modifying the final string to generate length of $min_word_count.
   +      $plain_string = explode(' ', $greeking);
   

   I think this should be 'Modify the final string to match the length of $min_word_count". However also why is this necessary and are these variables used at all?

Hi @catch, I have made the changes as you mentioned.

 // Modify the final string to match the length of $min_word_count.
       $plain_string = explode(' ', $greeking);
       $greeking = trim(implode(' ', array_slice($plain_string, 0, $min_word_count)), '.') . '. ';

The while loop in the code is not generating an exact N word sentence , its is going beyond that. the above snippet is just enforcing to generate the sentence equal to $min_word_count .

Applied patch #19 working fine
Thanks for the patch

Reran #25 for 10.1 and the tests pass

Also tested locally and confirm the tests fail without the fix.
Also tested locally the solution with devel generate and it worked.

+++ b/core/lib/Drupal/Component/Utility/Random.php
@@ -235,6 +235,9 @@ public function sentences($min_word_count, $capitalize = FALSE) {
+      // Modify the final string to match the length of $min_word_count.
+      $plain_string = explode(' ', $greeking);
+      $greeking = trim(implode(' ', array_slice($plain_string, 0, $min_word_count)), '.') . '. ';

These changes aren't necessary or part of the fix. If we were to make this change then we should change the docs:

   * @param int $min_word_count
   *   The minimum number of words in the return string. Total word count
   *   can slightly exceed provided this value in order to deliver
   *   sentences of random length.

But I don't understand why we need to do this.

#31.1 if we remove that code the tests added fail so think they are needed?
#31.2 min_word_count I don't follow?

Closed #3083954: Generated sample values for TextItemWithSummary should have short summary text as a duplicate

@alexpott

But I don't understand why we need to do this.

Not sure I know what you mean.

Guess after so long is this still needed by chance?

Since there’s been no follow up going to close out. If still valid please reopen maybe updating the summary to address the why