As per coding standard documentation at 'https://www.drupal.org/coding-standards/docs', @file tag docblock should not be there in the files that contain a namespaced class/interface/trait, whose file name is the class name with a .php extension.

CommentFileSizeAuthor
#3 removed-file-doc-block.patch2.45 KBbhawanac
removed-file-doc-block.patch2.46 KBbhawanac

Comments

bhawanac created an issue. See original summary.

AsadKamil’s picture

AsadKamil commented

It seems patch doesnt apply on 8.x branch.Please check the patch
Thanks

root@asad-Vostro-3550:/var/www/html/git/session_limit# git apply -v removed-file-doc-block_0.patch 
Checking patch src/Event/SessionLimitBypassEvent.php...
Checking patch src/Event/SessionLimitCollisionEvent.php...
Checking patch src/Event/SessionLimitDisconnectEvent.php...
Checking patch src/Form/SessionLimitForm.php...
Checking patch src/Form/SettingsForm.php...
Checking patch src/Services/SessionLimit.php...
error: while searching for:
<?php

/**
 * @file
 * Contains \Drupal\session_limit\Services\SessionLimit.
 */

namespace Drupal\session_limit\Services;

use Drupal\Core\PageCache\ResponsePolicy\KillSwitch;

error: patch failed: src/Services/SessionLimit.php:1
error: src/Services/SessionLimit.php: patch does not apply
root@asad-Vostro-3550:/var/www/html/git/session_limit#
bhawanac’s picture

bhawanac commented
StatusFileSize
new removed-file-doc-block.patch2.45 KB
bhawanac’s picture

bhawanac commented

patch #3 is the updated and correct patch.

AsadKamil’s picture

AsadKamil commented

The latest patch is applied cleanly to 8.x branch
Thanks

root@asad-Vostro-3550:/var/www/html/git/session_limit# git apply -v removed-file-doc-block_1.patch 
Checking patch src/Event/SessionLimitBypassEvent.php...
Checking patch src/Event/SessionLimitCollisionEvent.php...
Checking patch src/Event/SessionLimitDisconnectEvent.php...
Checking patch src/Form/SessionLimitForm.php...
Checking patch src/Form/SettingsForm.php...
Checking patch src/Services/SessionLimit.php...
Applied patch src/Event/SessionLimitBypassEvent.php cleanly.
Applied patch src/Event/SessionLimitCollisionEvent.php cleanly.
Applied patch src/Event/SessionLimitDisconnectEvent.php cleanly.
Applied patch src/Form/SessionLimitForm.php cleanly.
Applied patch src/Form/SettingsForm.php cleanly.
Applied patch src/Services/SessionLimit.php cleanly.
root@asad-Vostro-3550:/var/www/html/git/session_limit#
nkoporec’s picture

nkoporec
Primary language English
Location Slovenia
commented
Status: Needs review » Reviewed & tested by the community

Tested the patch and it's working fine.Moving to RTBC.

  • johnennew committed 5b6fed1 on 8.x-1.x authored by bhawanac 
    Issue #2773303 by bhawanac: Remove @file tag docblock from all the...
johnennew’s picture

johnennew commented
Status: Reviewed & tested by the community » Fixed

Fair enough! Committed to 8.x-1.x

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.