Hi,
Not sure what can cause this - after opening modal on node edit page - styles are changed, text is smaller etc. I tried to remove css file from module but it was not caused by that.

I use theme seven as admin theme.

CommentFileSizeAuthor
#10 define_ajax_theme_callback.patch1.54 KBkonst_8
#2 css.png74.6 KBRostislav Sergeenkov

Comments

loparr created an issue. See original summary.

Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented
StatusFileSize
new css.png74.6 KB

Hi @loparr,

Could you provide some more information or couple of screenshots illustrating the problem?

Editor Note module uses editor-note-ctools-style.css file to customize modal popup. All CSS styles are written using #modalContent prefix - see screenshot.
In theory if your theme HTML uses id="modalContent" somewhere else apart from Ctools popup used by Editor Notes it may cause a problem.
First of all I would recommend to open the source code of the page where you are using Editor Note field and search for id="modalContent". If this id is present somewhere else - this is a problem and it has to be replaced.
If not - I need more information to figure out the root cause of the issue.

Best regards,
Rostislav Sergeenkov

loparr’s picture

loparr commented

Hi,
I tried to remove modules' css, however the style changes after loading modal too.

It seems that the way the css is changed depends on what front theme I use. Now I use bootstrap , however the style of various elements is changed with bartik or garland as front theme as well.

Looking at the html code - the node edit page does not contain modalContent.

Please try this: use seven as admin theme, use bartik as front theme. Look at the notes table header - it has background: #e1e2dc; coming from seven theme css. However after editing a note and closing modal - the table header background color of notes is darker. Looking at css - the style comes from bartik.

Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented

@loparr, thank you for your investigation! It was very helpful.

ajax_render() called in editor_note_confirm_edit_page loads on action link click a bunch of CSS files from the default theme (bartik in your case) even in admin theme is different.

@import url("http://drupal7/themes/bartik/css/layout.css");
@import url("http://drupal7/themes/bartik/css/style.css");
@import url("http://drupal7/themes/bartik/css/colors.css");

That's why admin UI changes.
I need to figure out how to prevent such behavior.

Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented

Solved by adding

$_POST['ajax_page_state']['css'] = array();

before print ajax_render($output);

I've just added new 7.x-1.4 project release containing fix. Release will be available tomorrow when Drupal generates it from the release queue.

loparr’s picture

loparr commented

HI,
Works great. Thank you for quick solution.

Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented
Version: 7.x-1.x-dev » 7.x-1.4
Assigned: Unassigned » Rostislav Sergeenkov
Status: Active » Fixed
Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented
Status: Fixed » Closed (fixed)
loparr’s picture

loparr commented
Status: Closed (fixed) » Active

Hi,
sorry to reopen. I came across same problem under different circumstances - open existing note on node, close modal, add new note. After saving, styles are changed again. Saving whole node after gives white screen - error log says - PHP message: PHP Fatal error: Call to undefined function bootstrap_form_process() in .../html/includes/form.inc on line 1870.
It seems that the modal is still messing with current theme (I use bootstrap)

konst_8’s picture

konst_8 commented
StatusFileSize
new define_ajax_theme_callback.patch1.54 KB

To fix the issue we should define a theme callback for ajax menu paths.
Check ajax_base_page_theme for more info.
The patch is attached.

Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented
Assigned: Rostislav Sergeenkov » konst_8
Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented
Status: Active » Needs review
Rostislav Sergeenkov’s picture

Rostislav Sergeenkov commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.