1. Create a entity with one default and one additional translation.
2. Clone the entity additional translation.
3. Enforce the cloned entity to be new.
4. The change is propagated to the original entity and if you try to save it now -> entity storage exception about trying to save a new entity with an id that already exist.
Having cases where you are using entities with multiple translations and in some cases the user might trigger createDuplicate on a entity translation and later save the original entity will lead to data loss => this per definition is major.
ContentEntityBase::__clone should consider the enforceIsNew flag as well when overwriting the properties.
Commit
none
none
none
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | enforce_is_new_on_cloned_entity_translation_failing_test.patch | 1.29 KB | hchonov |
| enforce_is_new_on_cloned_entity_translation_test_with_fix.patch | 1.96 KB | hchonov |
Comments
Comment #2
hchonovComment #4
hchonovComment #5
penyaskitoGreat catch :)
Reviewed the code and the tests, fix looks good and the new clone test is right after other clone tests.
Comment #6
catchCommitted/pushed to 8.2.x and cherry-picked to 8.1.x. Thanks!