Problem/Motivation

When dealing with breakpoints, and more specifically with "em" breakpoints, you always need to use decimal values instead of integer ones.
Currently, superfish is casting the value as an integer, dropping everything after the decimal dot.

Proposed resolution

Cast as float instead of integer.

Remaining tasks

Patch, Review, Commit

User interface changes

None.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#2 superfish_floating-breakpoints_2769875-2.patch1.16 KBDuaelFr
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

DuaelFr created an issue. See original summary.

DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented
Title: Do not cast touchscreen & smallscreen breakpoint value as an integer » Do not break responsiveness by casting touchscreen & smallscreen breakpoint values as an integer
Issue summary: View changes
Status: Active » Needs review
FileSize
superfish_floating-breakpoints_2769875-2.patch1.16 KB

  • mehrpadin committed 46d5ffe on 7.x-1.x authored by DuaelFr 
    Issue #2769875 by DuaelFr: Do not break responsiveness by casting...

  • mehrpadin committed 3c0ab26 on 8.x-1.x authored by DuaelFr 
    Issue #2769875 by DuaelFr: Do not break responsiveness by casting...
mehrpadin’s picture

mehrpadin CreditAttribution: mehrpadin commented

Hey there,

Thanks, applied to both D7 and 8.

mehrpadin’s picture

mehrpadin CreditAttribution: mehrpadin commented
Status: Needs review » Fixed
DuaelFr’s picture

DuaelFr
he/him
Primary language French
Location Montpellier, France
CreditAttribution: DuaelFr as a volunteer and at Happyculture commented

\o/

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.