Hi,
Not sure how this happend, but in "actions" method of PollViewForm class we set "#ajax" option for "cancel" action few times, instead of adding it for "back" and "result" actions.
As result "View results" and "View poll" ajax form refresh does not work, buttons just redirect us to poll page.

poll_bug_ajax.png

CommentFileSizeAuthor
#3 poll-issue_2769691-3.patch922 bytesgilmord
poll_bug_ajax.png49.3 KBgilmord

Comments

gilmord created an issue. See original summary.

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Issue summary: View changes
gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
StatusFileSize
new poll-issue_2769691-3.patch922 bytes

Provided small git patch.

gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Priority: Normal » Major
Status: Active » Needs review
gilmord’s picture

gilmord
Location 🇺🇦Ukraine
commented
Priority: Major » Critical
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Priority: Critical » Major
Status: Needs review » Needs work
Issue tags: -bug fix +Needs tests

Not critical but good catch.

Some test would be nice, we already have javascript tests for this, shouldn't be too hard to extend it for this.

webflo’s picture

webflo commented
Title: Brocken ajax "View results" and "View poll" » Broken ajax "View results" and "View poll"

  • Berdir committed 66dd0f2 on 8.x-1.x authored by gilmord 
    Issue #2769691 by gilmord: Broken ajax "View results" and "View poll"
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Title: Broken ajax "View results" and "View poll" » Add tests: Broken ajax "View results" and "View poll"
Category: Bug report » Task
Priority: Major » Normal

Aw, no tests. Committed and keeping open as a task to add tests.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Category: Task » Bug report
Priority: Normal » Major
Status: Needs work » Fixed
Issue tags: -Needs tests

We've added some more real JS tests since then, maybe they cover this, if not then keeping a 2y old issue still open isn't going to help.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.