Closed (fixed)
Project:
Lightbox2
Version:
6.x-1.9
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
30 Jun 2008 at 19:12 UTC
Updated:
5 Oct 2009 at 23:47 UTC
Jump to comment: Most recent file
Comments
Comment #1
stella commentedAh, I changed it because it stopped appearing correctly for me. I guess it's because I've upgraded to FF 3. Let me look into it further.
Cheers,
Stella
Comment #2
gumdrop commentedI am getting that same issue in Firefox 3 also.
Comment #3
stella commentedNo, I can't reproduce it in FF 3. I've tried 3 different windows machines running FF3 and it appears in the correct place. What platform are you using?
Comment #4
gumdrop commentedWell it is certainly doing it for me. And I tried it with different themes/templates. The previous version was fine.
I am using the image node settings enabled.
However, no horizontal scroll bar. Just the x outside the frame as above...below the enlarge link.
Comment #5
se commentedHere is cropped screenshot, perhaps it helps ...
As for me, I am running FF2 on win xp..
Comment #6
stella commentedI still can't reproduce it and I'm using the default garland theme.
Can you send me a link to your site? My contact form is enabled if you wish to do so privately.
Cheers,
Stella
Comment #7
stella commentedThe attached patch should fix the issue. I still can't reproduce it on my test site - I've tried both versions of FF on 4 different machines, with 6 different themes! There must be something about my test site because I've since tried it on a different D6 site and I can reproduce your issue.
Anyway, attached patch should resolve the issue and I've committed it to CVS so it should appear in the next dev release, later today.
Comment #8
stella commentedIgnore last patch. Found the proper solution. The issue I was having on my site only affected multi-lingual sites which is why I couldn't reproduce the issue. The attached patch should work for all sites now. Firebug is very useful!
Cheers,
Stella
Comment #9
se commentedPatched .. "X" is fine now , but there is always horizontal scrollbar.. I browsed in gallery for while and scrolled area(even vertical) is getting larger after every prev or next click.. looks like something is incremented or added by browsing in lightbox??
Comment #10
gumdrop commentedThat fixed it for me on my FF3. Only time I get scroll bars is if I am using the html content. Which I think should be normal.
Comment #11
stella commentedThe attached patch should fix it - note you need to use this patch as well as the one from comment #8 above in order to fix both issues. This one just resolves the scrollbar issue.
gumdrop: the scrollbar issue is the firefox window scrollbars, not in the lightbox itself.
It was caused by what I believe to be a bad interpretation by Mozilla of
window.innerHeightandwindow.innerWidthwhich includes the scrollbar's width in it's calculation! Anyway the attached patch has a workaround for this.Cheers,
Stella
Comment #12
se commentedStella,
great work! Patches are applied and both solved announced issues..
Thanks!
Tomas
Comment #13
stella commentedI've had to roll back the scrollbar patch. It doesn't work reliably and I think it's better to have a bad scrollbar length rather than the overlay not covering the full page. Sorry.
Cheers,
Stella
Comment #14
UCFPowell commentedHas there been an update to Lightbox2? I downloaded it today, and have the issue mentioned above. My X appears below the photo.
http://www.jetblackmotorsports.com/ourfacility
Comment #15
UCFPowell commentedNevermind I fixed it. I removed the second line with the 29% width.
#imageData #bottomNav { lightbox.css (line 153)
height:66px;
width:29%;
}
Comment #16
stella commentedUCFPowell: it's currently still only available in the dev version.
Comment #17
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.
Comment #18
hansamurai commentedI know this is closed but there's a side effect from leaving the scroll bar issue be: when I use the right arrow key to go to the next image, the screen stretches more and the lightbox moves further and further to the left as the window expands to the right.
I don't feel like it is appropriate to re-open this issue because of that, more of a heads up.
Comment #19
loloyd commentedThanks to UCFPowell for the quick fix on the "ugly" placement of X (close lightbox) button. Thanks to Stella too, of course, for making Lightbox2 module as powerful as it is now. Removing the "width:29%;" bit (or at least commenting) on line 155 of the file css\lightbox.css transfers the X button to the bottom-right side of the lightbox making things less uglier, aka prettier :-D.
Sorry for sounding awfully newbish but I also found that the "width:29%;" bit does not appear in the file css\lightbox-rtl.css. Shouldn't it be duly removed from the file "css\lightbox.css" as well?
Comment #20
stella commentedIf you use the latest dev version of the lightbox2 module, the correct lightbox css files are included, so you have no need to make changes. It also fixes a couple of other issues too.
Comment #21
Stewx commentedI'm still getting this problem
Comment #22
Stewx commentedSee attachment:
Comment #23
Stewx commentedMy bad, I didn't clear my site's cache.
Comment #24
zooki commentedMozilla 3.04 here, and x in wrong place. latest lightbox2
Comment #25
zooki commentedComment #26
stella commentedzooki: please use the dev version of the lightbox2 module.
Comment #27
stella commentedReleased in Lightbox2 6.x-1.9 and 5.x-2.9.
Cheers,
Stella
Comment #29
greenbonsai commentedThis bug doesn't appear to have ever been fixed or even acknowledged. It's been over a year since hansamurai's post, but recently I administered Lightbox2 6.x-1.9 and it seems to be working great except in my Firefox 3.5. Like hansamurai explained above when I use the right arrow key to flip through the images it eventually starts pushing the whole page (everything within the page div and including the lightbox itself) to the left until it's completely out of the browser window.
I understand this post is very old so I may just report it as a recent bug as I haven't found any other documentation on this.