In book module, visiting the form where you can outline a whole book gives this error:

notice: Undefined variable: menu_name in /Users/Shared/www/drupal-6/modules/book/book.module on line 1081.

This was apparently introduced in [#231587: cache_menu: data blobs identical and huge;] . This results in an incorrect cid - so probably the caching is totally broken.

CommentFileSizeAuthor
#2 book-cid-276846-6x-2.patch905 bytespwolanin
#1 book-cid-276846-1.patch850 bytespwolanin

Comments

pwolanin’s picture

pwolanin commented
Title: malformed cid due to undefined variable » malformed book cid due to undefined variable
Status: Active » Reviewed & tested by the community
StatusFileSize
new book-cid-276846-1.patch850 bytes

This was probably a copy-paste error from the analogous function in menu.inc where $menu_name is actually defined.

Trivial fix.

pwolanin’s picture

pwolanin commented
StatusFileSize
new book-cid-276846-6x-2.patch905 bytes

backport for 6.x.

damien tournoud’s picture

damien tournoud commented
Title: malformed book cid due to undefined variable » Malformed book cid due to undefined variable

Ok, looks good.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to CVS HEAD. Thanks.

pwolanin’s picture

pwolanin commented
Version: 7.x-dev » 6.x-dev
Status: Fixed » Reviewed & tested by the community

doesn't look like this went into 6.x?

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Oops, I had applied and tested it on my Drupal 6 tree but then somehow omitted the actual Drupal 6 commit. It was still waiting to be committed. Committed it to DRUPAL-6. Thanks pwolanin.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.