Problem/Motivation

When running some migration, source plugins stopped with missing source plugin exceptions (e.g. Drupal\comment\Plugin\migrate\source\d7\Comment)
This exception was occured in DrupalSqlBase->checkRequirements method. This method executes moduleExists method in self.

DrupalSqlBase->moduleExists method check module existence from returned data of getSystemData method.
And this method gets data from system table on database.

But system table was removed in core. https://www.drupal.org/node/1813642
So, this method will return empty array every time.
Also moduleExists methos will return FALSE.

Proposed resolution

I don't know to fix getSystemData method.
Temporary, moduleExists method can fix use following code

Drupal::moduleHandler()->moduleExists($module);

But this is for module existence check only. I'm not sure that getSystemData method is used by moduleExists method only.

Remaining tasks

Need works.

Comments

barami created an issue. See original summary.

barami’s picture

barami commented
Issue summary: View changes
chx’s picture

chx commented
Status: Active » Closed (works as designed)

Please see the change notice you linked:

Introduced in branch: 8.x

you are trying to migrate a D8 site to D8, this is not yet supported.

barami’s picture

barami commented
Status: Closed (works as designed) » Active

chx//

No, As i mentions above post (Drupal\comment\Plugin\migrate\source\d7\Comment), I'm had tried migrate drupal 7 site to 8...
I finished migrate after modify that code, And never tried twice.
But i clearly tried migration from drupal 7 to drupal 8..

I wonder what's my fault?

PS. I used d7_comment source in yml.
Here is my custom migration module code. https://github.com/Barami/migrate_barami

barami’s picture

barami commented
Status: Active » Closed (outdated)

I think this is not important.
When this problem is reproduced, I'll reopen this issue. But I don't feel to try this.

I'm sorry for angry with your comment.