The 2026 Drupal Business Survey is open. Your response will help shape the future of the Drupal business ecosystem.We have a few failing tests. We need to fix those so they all pass before we get a stable release.
| Comment | File | Size | Author |
|---|---|---|---|
| #18 | 276486-fix-tests-17.patch | 16 KB | kmoll |
| #9 | 276486-fix-test-9.patch | 15.63 KB | kmoll |
| #5 | 276486-fix-tests-5.patch | 15.36 KB | kmoll |
| #2 | 276486-fix-tests-1.patch | 13.41 KB | kmoll |
Comments
Comment #2
kmoll commentedI have updated the functionality. Needed to make a few small tweaks to the code, but now all tests pass.
Comment #3
naveenvalechaTesting this on drupal ci
Comment #5
kmoll commentedSome of the failing tests are due to the report directive not using the base path. Updated patch.
Comment #6
kmoll commentedComment #9
kmoll commentedOne of the tests is failing because it returns a 200 if the IP address is localhost. The test bot runs on localhost. But the base root is added to the whitelist, so if the origin matches, it will allow it. If it is different then IMO, it should still fail. If the the IP is localhost, its either the test-bot or a development environment, so I think that we would want to to work this way for testing purposes. I was testing on a VM which is why my tests were passing.
Here is a new patch, and I made another update on for the report directives url.
Comment #10
kmoll commentedComment #11
badjava commentedI removed the waiting for branch tests to pass so let's see what happens.
Comment #18
kmoll commentedTest was failing due to 1 test, I've updated the event subscriber to add the $base_url, not the $base_root.
Comment #19
jribeiro commented+1 RTBC
Comment #21
badjava commentedThank you @kmoll for fixing this and everyone else for pitching in!