New regions needs to be added in order to implement CSS for the design properly in this task: https://www.drupal.org/node/2764233.
New regions should be:
'brand'
'top_navigation'
'primary_navigation'
'search'
'secondary_navigation'
'messages'
'footer_bottom'
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | Pistachio-2764857-add-regions-change-markup.patch | 3.37 KB | adoo |
Comments
Comment #2
adoo commentedComment #3
adoo commentedComment #4
adoo commentedI added regions.
Comment #5
adoo commentedComment #6
adoo commentedChange copyright region to footer_bottom
Comment #7
adoo commentedChange order of the regions, add container wrappers.
Comment #8
adoo commentedComment #9
davidhernandezMost of these changes are fine. We can probably get rid of the main layout-container. That came with the template from Classy, but if it isn't needed we can remove it.
I talked to Adrian about this and we agree that we could get rid of the 'if' but it might be good to leave it as an example.
Comment #10
adoo commentedRemove layout-container div, change the markup and add container to the menu and brand.
Comment #11
davidhernandezThis looks fine. There are a couple things I'd like to do different, but we can follow up with that. Right now I want to get the regions in so we can work on the CSS.
Also, @adoo, I'm not too found of these 'if's for adding classes.
...but we can leave them for now. One thing I don't like is that this leaves a lot of extra white space in the class attribute. You can see it in the page source. I added dashes in the if to remove the extra whitespace. You can see that after it is committed.
I also updated to comment block with the new regions.
Comment #13
davidhernandezComment #14
adoo commentedChange a class in the template.
Comment #15
adoo commentedWill open new issue for the the class change.