Problem/Motivation

Currently, the FieldPermissionTypeInterface declares 2 field-config-form-specific methods, that are only applicable to the custom access plugin.

Proposed resolution

Move these methods (buildAdminForm() and submitAdminForm()) to a new interface, and have CustomAccess implement that interface.

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 2764479-02.patch14.21 KBjhedstrom
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

jhedstrom created an issue. See original summary.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Active » Needs review
FileSize
2764479-02.patch14.21 KB

I removed the 'has' from the various interfaces here since it seemed redundant.

  • jhedstrom committed 7ccee4a on 8.x-1.x 
    Issue #2764479 by jhedstrom: Split admin form methods into separate...
jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
CreditAttribution: jhedstrom at Phase2 for Workday, Inc. commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.