Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.User warning: The following module is missing from the file system: module_filter. In order to fix this, put the module back in its original location. For more information, see the documentation page (link is external). in _drupal_trigger_error_with_delayed_logging() (line 1128 of E:\green-acorn\workspace\green-acorn-status-monitor\includes\bootstrap.inc).
Easy fix, just add a module_exists().
/**
* Implements hook_js_alter().
*/
function adminimal_js_alter(&$javascript) {
// Fix module filter available updates page.
if (module_exists('module_filter') && isset($javascript[drupal_get_path('module','module_filter').'/js/update_status.js'])) {
$javascript[drupal_get_path('module','module_filter').'/js/update_status.js']['data'] = drupal_get_path('theme', 'adminimal') . '/js/update_status.js';
}
}
| Comment | File | Size | Author |
|---|---|---|---|
| #32 | adminimal_theme-2763581-32.patch | 694 bytes | joelpittet |
| #22 | adminimal_theme-2763581-22.patch | 653 bytes | djalxs |
| #4 | adminimal_theme-2763581-4.patch | 832 bytes | Alan D. |
Comments
Comment #2
TommyChrisWorks, please commit it!
Comment #3
T.Mardi CreditAttribution: T.Mardi commentedWorks great, thank you.
Comment #4
Alan D. CreditAttribution: Alan D. commentedHere's the patch since this error has been frequency noticed :)
I think this is related to changes in Drupal 7.50 error reporting, so affected users are likely to increase as users update.
Comment #5
JoelAddison CreditAttribution: JoelAddison commentedThe patch in #4 works. It would be great to get this in.
Comment #6
iryston CreditAttribution: iryston as a volunteer commentedThe patch in #4 works, thank you.
Comment #7
co2ncos1to CreditAttribution: co2ncos1to commentedOoo my.. it's work. Thank u
Comment #8
Wil B. Samson CreditAttribution: Wil B. Samson commentedIt's not a matter if the module is enabled or even installed. I just spun up a clean 7.50 (on Pantheon) and added Adminimal - the error appeared without having ever installed Module Filter. If I deactivate Adminimal, the error disappears.
Comment #9
iryston CreditAttribution: iryston as a volunteer commented@RarelyRed The patch in #4 returns TRUE if the module is both installed and enabled, FALSE otherwise
Comment #10
Alan D. CreditAttribution: Alan D. commentedThere was a change in reporting with Drupal 7.50.
Drupal 7.44 and below, it would silently go, if module doesn't exist, return nothing, but now it actually reports an warning, hey your trying to get a path of something that doesn't exist. So calls to drupal_get_path() now need to be wrapped.
Comment #11
markdorisonPatch in #4 works as expected.
Comment #12
choster CreditAttribution: choster commentedAnother confirmation that #2763581-4: Error if module_filter not enabled (Drupal 7.50) does the trick.
Comment #13
jenlampton+1 for RTBC
Comment #14
Alan D. CreditAttribution: Alan D. commentedBumping priority, starts to chock the log tables with messages if not resolved :(
Comment #15
thelmer CreditAttribution: thelmer at Adapt commented+1 for RTBC
Comment #16
aken.niels@gmail.comAnother positive result here, +1. Would love to see a quick release for this one.
Comment #17
annared CreditAttribution: annared commentedHi,
i patched the theme but i still got the same error. Any idea?
Thanks
Comment #18
Alan D. CreditAttribution: Alan D. commentedThis part of the message? "The following module is missing from the file system: module_filter."
Look at all of your other modules and themes that have the string "module_filter", and that would be the likely cause. Totally useless info by default "line 1128 of includes\bootstrap.inc" to debugging via Drupal, unless you add a backtrace there to see where it gets called from.
Comment #19
anthony.bouch CreditAttribution: anthony.bouch as a volunteer commentedThe patch solved this for me as well.
Comment #20
rudam CreditAttribution: rudam commented#4 works!
Comment #21
calbasi#4 works for me too
Comment #22
djalxs CreditAttribution: djalxs as a volunteer and commentedI have sightly modified the patch so as there aren't nested if conditional statements. Although it doesn't seem like much, nested conditionals take longer to process and if there are many little nested conditionals, eventually they all add up.
Comment #23
Alan D. CreditAttribution: Alan D. commentedCalc diff of between 10ms and 42ms with 1,000,000 loops, which is like 0.000042ms per conditional. Lack of readability negates any benefit imho.
Watch the line length and coding standards, spaces between the dots etc.
Comment #24
aseabrook CreditAttribution: aseabrook as a volunteer commentedIs anyone else encountering the following error?
User warning: The following theme is missing from the file system: adminimal_theme. For information about how to fix this, see the documentation page. in _drupal_trigger_error_with_delayed_logging() (line 1128 of ...)I applied the patch in #4 thinking that somehow it might resolve my above error as well but unfortunately it didn't.
I also attempted to remove the row in my db that mentions adaptive theme as per the Drupal docs (https://www.drupal.org/node/2487215) but that also didn't make a difference.
Comment #25
Alan D. CreditAttribution: Alan D. commentedUnrelated: You must have removed (or moved) the theme. Same idea as a module, restoring the code for the theme first, then disable the theme. After that, you can delete the theme code without this warning
https://www.drupal.org/node/2487215
Or remove the line from the sites system directly via SQL (backup in case you delete the wrong line!)
Comment #26
aken.niels@gmail.comPatch in #22 seems to contain a critical typo: modue_filter, which should obviously contain module_filter. No sure about the performance boost though, as noted in #23.
Comment #27
jjsanbra CreditAttribution: jjsanbra commentedHi, were I got to paste de hook?
Comment #28
uno CreditAttribution: uno commentedI liked the theme and installed it, with plan to use it as replacement for Seven everywhere, but after seeing missing module_filter error, even on fresh installs, checked the theme files and found them bloated with module_filter references. Just take a look into js files, especially /js/update_status.js ...
I found out that after removing this file from the theme module_filter missing error disappears.
Since there is no reference to /js/update_status.js in theme's .info file, you'd have to remove lines 239 - 247 in template.php file, so that the following code is there no more:
/**
* Implements hook_js_alter().
*/
function adminimal_js_alter(&$javascript) {
// Fix module filter available updates page.
if (isset($javascript[drupal_get_path('module','module_filter').'/js/update_status.js'])) {
$javascript[drupal_get_path('module','module_filter').'/js/update_status.js']['data'] = drupal_get_path('theme', 'adminimal') . '/js/update_status.js';
}
}
Or, if you want to keep the code, just clear the line 241, by deleting */
Flush caches afterwards.
I found no problems after removing those lines, whatsoever.
Did not try to analyze whether this was an error or an effort, but if this was an effort to promote mentioned module, it is going to be counterproductive, both for the theme and the module.
Comment #29
Jaypan CreditAttribution: Jaypan at Jaypan commentedBoth the patch in #4 and #22 are good. I've was about to submit a patch and found this thread, and the patch I was to submit was identical to #22.
Comment #31
ANDiTKO CreditAttribution: ANDiTKO as a volunteer commentedFixed in latest version. Thank you all and especially @Alan D. and @djalxs for providing patches.
Comment #32
joelpittetThere's a typo in this patch that got committed
'modue_filter'vs'module_filter'Comment #33
markdorisonDoh! Patch in #32 looks good.
Comment #34
kurkuma CreditAttribution: kurkuma as a volunteer and commentedHere is a patch for the stable release of the theme (7.x-1.24), for those ones that do not want or cannot use the dev version of the theme in production servers and do not want to have patches manually applied in their code.
Comment #35
Alan D. CreditAttribution: Alan D. commentedrtbtc from me too, it's nice to see the space added back ") . '" ;)
Comment #36
gambryAny chance to have this committed?
Comment #37
llslim CreditAttribution: llslim commented#34 works for me.
Comment #38
andrea.cavattoni CreditAttribution: andrea.cavattoni commented#34 works! thanks.
Comment #39
gateway69 CreditAttribution: gateway69 commentedwhy not push this change? :P
Comment #40
roderickgadellaabsl CreditAttribution: roderickgadellaabsl commentedMaybe it's time to push the fix to stable? This issue has been around for ages. Makes me wonder if this project is abandoned..
Comment #41
joelpittet#34 is patching stable release, I'm hiding it for the committer. #32 was RTBC'd
Comment #42
ressa CreditAttribution: ressa at Ardea commentedIt would be great with a fresh release, to get this fixed.
Comment #43
Jaypan CreditAttribution: Jaypan commentedComment #44
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commentedComment #46
andrey.troeglazov CreditAttribution: andrey.troeglazov at DrupalJedi commented