Convert web tests to browser tests for link module

As of July 11, core's 8.2.x branch test has 18,617 passes, but the patch shows 18,614.

The patch still applies, so I'm running the testbot again to see if the number changes.

@mile23, @klausi
Also you have to keep in mind, depending on the batch processes in some of the update path / config import etc. tests the amount of assertions might vary on a test by test base anyway.

This is just some quick review. Sorry for slacking on some of the reviews recently.

1. +++ b/core/modules/field_ui/tests/src/Functional/FieldUiTestTrait.php
   @@ -0,0 +1,127 @@
   +  public function fieldUIAddNewField($bundle_path, $field_name, $label = NULL, $field_type = 'test_field', array $storage_edit = array(), array $field_edit = array()) {
   ...
   +  public function fieldUIAddExistingField($bundle_path, $existing_storage_name, $label = NULL, array $field_edit = array()) {
   ...
   +  public function fieldUIDeleteField($bundle_path, $field_name, $label, $bundle_label) {
   

   This is also maybe a bad question: Is there a particular reason it to be public?

2. +++ b/core/modules/link/tests/src/Functional/LinkFieldTest.php
   @@ -329,9 +329,9 @@ function testLinkTitle() {
   -    $this->renderTestEntity($id);
   -    $expected_link = \Drupal::l($title, Url::fromUri($value));
   -    $this->assertRaw($expected_link);
   +    $output = $this->renderTestEntity($id);
   +    $expected_link = (string) \Drupal::l($title, Url::fromUri($value));
   +    $this->assertContains($expected_link, $output);
      }
   

   I like the new variant. Its more explicit ...

3. +++ b/core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php
   @@ -64,6 +67,10 @@ protected function assertText($text) {
   +      // It will provide the value HTML entity decoded, so we need to do the
   +      // same here for the text to actually match.
   

   Can we clarify that the PHP DOM api does the decoding, not mink/browserkit?

I'm postponing this on #2773733: Fix AssertLegacyTrait::assert(No)Text to handle html encoded strings (part 3). There also other conversions needing that, so let's fix it in a dedicated issue.

Un-postponing as #2773733: Fix AssertLegacyTrait::assert(No)Text to handle html encoded strings (part 3) is in. As \Drupal\Tests\field_ui\Functional\FieldUiTestTrait is new code, it should not use deprecated methods.

assertNoFieldByName() was implemented in the meantime.

Re-rolled.

The test fails if the change is reverted to assertNoFieldByName(), unless the second and third parameters are removed (I have tested this locally). I can upload the patches if required?

I suggest it is better to stick with the change in #15 rather than a change to the parameters of a deprecated function.

Requires re-roll due to #2776975: March 3, 2017: Convert core to array syntax coding standards for Drupal 8.3.x RC phase.

Re-rolled.
Re-instated reference to assertNoFieldByName() now that it has been corrected.

I'm sorry, that was careless of me.

Committed a333b55 and pushed to 8.4.x. Committed 5a5e2cc and pushed to 8.3.x. Thanks!

There was a new test in 8.4.x so on cherry-pick I just merged it correctly - the new test is testLinkTypeOnLinkWidget() and it still is not in 8.3.x.