Remove redundant NodeRevisionController

Thanks @jonathanjfshaw.
This is an early patch, not really sure if we can have security problems here. But it works as far as I tested.

+++ b/src/Controller/NodeRevisionController.php
@@ -45,264 +45,28 @@ class NodeRevisionController extends EntityComparisonBase {
       'title' => $this->t('Standard'),
-      'url' => Url::fromRoute('diff.revisions_diff', array(
-        'node' => $nid,
+      'url' => Url::fromRoute('entity.node.revisions_diff', array(
+        'node' => $entity->id(),
         'left_vid' => $left_vid,
         'right_vid' => $right_vid,
       )),
     );
     $links['raw_plain'] = array(
       'title' => $this->t('Markdown'),
-      'url' => Url::fromRoute('diff.revisions_diff', array(
-        'node' => $nid,
+      'url' => Url::fromRoute('entity.node.revisions_diff', array(
+        'node' => $entity->id(),

+++ b/src/Form/RevisionOverviewForm.php
@@ -343,7 +343,7 @@ class RevisionOverviewForm extends FormBase {
     $redirect_url = Url::fromRoute(
-      'diff.revisions_diff',
+      'entity.node.revisions_diff',
       array(

I don't think those changes are correct, we still use our route now?

+++ b/diff.routing.yml
@@ -1,4 +1,4 @@
-diff.revisions_diff:
+entity.node.revisions_diff:

actually yes, just changed it to make it fit. Should I keep it as it was?

Ok, let's start again, tried something different. seems to work.

This should fix the tests. :)

1. +++ b/diff.routing.yml
   @@ -1,5 +1,5 @@
    diff.revisions_diff:
   -  path: '/node/{node}/revisions/view/{left_vid}/{right_vid}/{filter}'
   +  path: '/node/{node}/revisions/view/{left_revision}/{right_revision}/{filter}'
   

   hm, why change the slug names? We want to get rid of this eventually completely but until then, I'd try to keep the changes as minimal as possible.

2. +++ b/src/Controller/GenericRevisionController.php
   @@ -210,8 +210,9 @@ class GenericRevisionController extends EntityComparisonBase {
            );
            $revision_date = $this->date->format($revision->getRevisionCreationTime(), 'short');
   +        $url = $entity_type_id != 'node' ? "entity.$entity_type_id.revisions_diff": 'entity.node.revision';
            $revision_link = $this->t($revision_log . '@date', array(
   

   ah, I see why you tried to rename...

   but this is not a url, it is a route name.

Added diff route function. Just not really sure if the diff_route function should avoid changing the variables on the route for leaving it as left_vid and right_vid?

Strange, it passes locally.

+++ b/src/Controller/GenericRevisionController.php
@@ -210,9 +210,9 @@ class GenericRevisionController extends EntityComparisonBase {
-        $url = $entity_type_id != 'node' ? "entity.$entity_type_id.revisions_diff": 'entity.node.revision';
+        $route_name = $entity_type_id != 'node' ? "entity.$entity_type_id.revisions_diff": 'entity.node.revision';
         $revision_link = $this->t($revision_log . '@date', array(
-            '@date' => $this->l($revision_date, Url::fromRoute($url, array(
+            '@date' => $this->l($revision_date, Url::fromRoute($route_name, array(
               $entity_type_id => $revision->id(),

you should be able to replace this one now too?

Looks like all the calls are on this controller, so maybe better to make a non-tatic method here?

Refactored more code. Moved the function. :D

Better now probably?

+++ b/src/Controller/GenericRevisionController.php
@@ -351,4 +327,39 @@ class GenericRevisionController extends EntityComparisonBase {
+   * @param boolean $raw_plain
+   *   Flag to determinate if the route should add a raw_plain filter.
...
+  protected function diffRoute(EntityInterface $entity, $left_vid, $right_vid, $raw_plain = FALSE) {

boolean seems to restricting.

Just add $filter as argument, NULL by default, if set, add it to the parameters.

Changes made.

I was blind! This should work better!

I think this looks good now.

Yay, committed. :-)