Array was modified by the user comparison function in ConfigDependencyManager::getDependentEntities()

Problem/Motivation

A random fail has been detected in Drupal\comment\Tests\CommentFieldsTest::testCommentInstallAfterContentModule()

exception: [Warning] Line 177 of core/lib/Drupal/Core/Config/Entity/ConfigDependencyManager.php:
uasort(): Array was modified by the user comparison functionuasort(Array, Array) (Line: 177)
Drupal\Core\Config\Entity\ConfigDependencyManager->getDependentEntities('config', 'field.field.node.article.comment') (Line: 256)
Drupal\Core\Config\ConfigManager->findConfigEntityDependents('config', Array, Object) (Line: 265)
Drupal\Core\Config\ConfigManager->findConfigEntityDependentsAsEntities('config', Array, Object) (Line: 298)
Drupal\Core\Config\ConfigManager->getConfigEntitiesToChangeOnDependencyRemoval('config', Array, ) (Line: 590)
Drupal\Core\Config\Entity\ConfigEntityBase::preDelete(Object, Array) (Line: 193)
Drupal\field\Entity\FieldConfig::preDelete(Object, Array) (Line: 357)
Drupal\Core\Entity\EntityStorageBase->delete(Array) (Line: 366)
Drupal\Core\Entity\Entity->delete() (Line: 596)
Drupal\Core\Config\Entity\ConfigEntityBase::preDelete(Object, Array) (Line: 406)
Drupal\field\Entity\FieldStorageConfig::preDelete(Object, Array) (Line: 357)
Drupal\Core\Entity\EntityStorageBase->delete(Array) (Line: 366)
Drupal\Core\Entity\Entity->delete() (Line: 192)
Drupal\comment\Tests\CommentFieldsTest->testCommentInstallAfterContentModule() (Line: 1057)
Drupal\simpletest\TestBase->run(Array) (Line: 723)
simpletest_script_run_one_test('199', 'Drupal\comment\Tests\CommentFieldsTest') (Line: 59)

Have no idea how this happens... I've run the test well over 100 times locally - no fail.

    $graph = $this->getGraph();
    uasort($graph, array($this, 'sortGraph'));
    return array_replace(array_intersect_key($graph, $dependencies), $dependencies);

  public function sortGraph(array $a, array $b) {
    $weight_cmp = SortArray::sortByKeyInt($a, $b, 'weight') * -1;

    if ($weight_cmp === 0) {
      return SortArray::sortByKeyString($a, $b, 'component');
    }
    return $weight_cmp;
  }

Proposed resolution

The graph is sorting on the component key added by the Graph object. It was assumed this was equivalent to the config object name - it is not. Therefore the patch adds the 'name' key and value to the graph so it can use it in the sort. Also it removes the array_reverse() since this doesn't have the expected impact on an already sorted list where the sort is on both weight and alphabet.

Remaining tasks

User interface changes

None

API changes

None - the ConfigDependencyManager public methods now actually return things in the expected order. Previously they correctly ordered things according to dependency (which is the vital thing) but sometimes messed up alphabetical sorting (which is a nice to have - just so things are repeatable and not dependent on PHP version).

Data model changes

None