As this SafeMarkup::checkPlain going to be deprecated this is now replaced with Html::escape().

CommentFileSizeAuthor
#7 token_2756241_4.patch4.04 KBChandan Chaudhary
#4 token_2756241_4.patch4.04 KBChandan Chaudhary
#2 2756241-2.patch1.88 KBrajeshwari10

Comments

rajeshwari10 created an issue. See original summary.

rajeshwari10’s picture

rajeshwari10 commented
Status: Active » Needs review
StatusFileSize
new 2756241-2.patch1.88 KB
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/token.install
@@ -18,7 +18,7 @@ function token_requirements($phase = 'runtime') {
         $problems = array_unique($problem['problems']);
-        $problems = array_map('\Drupal\Component\Utility\SafeMarkup::checkPlain', $problems);
+        $problems = array_map('\Drupal\Component\Utility\Html', $problems);

this is not valid, array_map expects a method, not a class.

Chandan Chaudhary’s picture

Chandan Chaudhary commented
Status: Needs work » Needs review
StatusFileSize
new token_2756241_4.patch4.04 KB

I agree with Berdir, it should have method and not a class

I have update the patch.

Status: Needs review » Needs work

The last submitted patch, 4: token_2756241_4.patch, failed testing.

The last submitted patch, 4: token_2756241_4.patch, failed testing.

Chandan Chaudhary’s picture

Chandan Chaudhary commented
Status: Needs work » Needs review
StatusFileSize
new token_2756241_4.patch4.04 KB

Retesting the patch as previous failed due to 'Checkout Error The git checkout returned an error. Error Code: 128'

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Don't forget to post an interdiff when updating an existing patch: https://www.drupal.org/documentation/git/interdiff

Committed, thanks.

  • Berdir committed 6bbc75b on 8.x-1.x authored by rajeshwari10 
    Issue #2756241 by Chandan Chaudhary, rajeshwari10: Removed deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajeshwari10’s picture

rajeshwari10 commented