Convert web tests to browser tests for language module

Reroll after #2750941: Additional BC assertions from WebTestBase to BrowserTestBase
Also fixed couple of failures.

Applying the patch gives us this, which is out of scope:

	modified:   core/tests/Drupal/FunctionalTests/AssertLegacyTrait.php
	modified:   core/tests/Drupal/KernelTests/KernelTestBase.php
	modified:   core/tests/Drupal/Tests/BrowserTestBase.php
	modified:   core/tests/Drupal/Tests/WebAssert.php

So I'm guessing the other trait issues will make those changes and this will eventually need re-work.

Should we postpone on those?

Agreed, let's postpone on those.

All in, now.

+++ b/core/modules/language/tests/src/Functional/LanguageListTest.php
@@ -176,9 +176,20 @@ function testLanguageList() {
+    // First create the NL language.
+    $edit = array(
+      'predefined_langcode' => 'nl',
+    );
+    $this->drupalPostForm('admin/config/regional/language/add', $edit, 'Add language');
+
+    // Load the form which has now the additional NL language option.
     $this->drupalGet('admin/config/regional/language');
-    $extra_values = '&site_default_language=nl';
-    $this->drupalPostForm(NULL, array(), t('Save configuration'), array(), array(), NULL, $extra_values);
+
+    // Delete the NL language in the background.
+    $language_storage = $this->container->get('entity_type.manager')->getStorage('configurable_language');
+    $language_storage->load('nl')->delete();
+
+    $this->drupalPostForm(NULL, array('site_default_language' => 'nl'), 'Save configuration');

This change is a bit weird. This language wasn't needed before

Certainly needs work based upon #22

LanguageTourTest will work with BTB after #2767275: Convert web tests to browser tests for tour module

I replace

+++ b/core/modules/language/tests/src/Functional/LanguageListTest.php
@@ -176,9 +176,20 @@ function testLanguageList() {
+    // First create the NL language.
+    $edit = array(
+      'predefined_langcode' => 'nl',
+    );
+    $this->drupalPostForm('admin/config/regional/language/add', $edit, 'Add language');
+
+    // Load the form which has now the additional NL language option.
     $this->drupalGet('admin/config/regional/language');
-    $extra_values = '&site_default_language=nl';
-    $this->drupalPostForm(NULL, array(), t('Save configuration'), array(), array(), NULL, $extra_values);
+
+    // Delete the NL language in the background.
+    $language_storage = $this->container->get('entity_type.manager')->getStorage('configurable_language');
+    $language_storage->load('nl')->delete();
+
+    $this->drupalPostForm(NULL, array('site_default_language' => 'nl'), 'Save configuration');

by

    // Ensure that NL cannot be set default when it's not available.
    $this->drupalGet('admin/config/regional/language');
    try {
      $this->drupalPostForm(NULL, array('site_default_language' => 'nl'), t('Save configuration'));
      $this->fail('Form validation InvalidArgumentException thrown but not caught.');
    }
    catch (\InvalidArgumentException $e) {
      $this->assertEquals($e->getMessage(), 'Input "site_default_language" cannot take "nl" as a value (possible values: xx).');
    }
    $this->assertFieldChecked('edit-site-default-language-xx', 'The previous default language still selected.');

Original code doesn't work anymore.

I can't do interdiff because #2770921: Feb 21st: Convert chunk of WTB to BTB by just moving classes, changing use statements adding traits already move some files and i cannot apply previous patch without fails.

Remove changes that are not relevant to this issue.

Sorry for making this issue so messy. I tried. I failed.

Addressed test failures.

I went through the changes and they look alright!

+++ b/core/modules/language/tests/src/Functional/LanguageListTest.php
@@ -177,8 +180,7 @@ function testLanguageList() {
-    $extra_values = '&site_default_language=nl';
-    $this->drupalPostForm(NULL, array(), t('Save configuration'), array(), array(), NULL, $extra_values);
+    $this->drupalPostForm(NULL, array('site_default_language' => 'nl'), t('Save configuration'));

I guess this was simply not needed before.

@dawehner FYI: That change is because the BTB version of drupalPostForm() has slightly different parameters to the WTB version.

Fair :)

As done in #26, i try catch \InvalidArgumentException because we cannot send not existed site_default_language like before.

I also keep @exception annotations removed which make tests success in case Exception is catched, which is not the purpose.

I cannot generate interdiff since 8.4.x add to much changes in code.

I fix some array to short array.
I came back to solution in #20.

Sorry for the mess.

What to do with core/modules/language/src/Tests/Update/LanguageSelectWidgetUpdateTest.php ?
Does the conversion of this file should be done in another issue or in this one ?

We can split the Tour test into a separate issue and try to get the rest for the Language module ready, setting back to needs work for that.

I revert LanguageTourTest conversion. Follow LanguageTourTest conversion on #2871740: Convert web tests to browser tests LanguageTourTest for language module

Manually checked if everything was moved, updated the IS to reflect the changes done and the follow ups.

All previous feedback has been addressed and I see no issues with the current changes.

Committed/pushed to 8.4.x, thanks!