Problem/Motivation

The docs about the folder location where test files should go is not correct in \Drupal\Tests\BrowserTestBase and \Drupal\simpletest\BrowserTestBase

Proposed resolution

Make docs match what we use (and what will work)

Remaining tasks

None
(maybe look for a handbook page on d.o?)

User interface changes

NA

API changes

NA

Data model changes

NA

CommentFileSizeAuthor
#2 2754541-1.patch1.01 KBwebflo

Comments

webflo created an issue. See original summary.

webflo’s picture

webflo commented
Status: Active » Needs review
Issue tags: +Documentation
StatusFileSize
new 2754541-1.patch1.01 KB
yesct’s picture

yesct commented

I'll look at this now.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Perfect! Thanks a ton!

yesct’s picture

yesct commented
Issue summary: View changes

I looked at if this is getting all the locations with some ag and greps like:

(in middle lines of block comments)

ag -Q "/Functional" core | grep ".*:.*:.*\* " | grep Tests
ag -Q "\Functional" core | grep ".*:.*:.*\* " | grep Tests

also checks if all the Functional namespace classes *are* in src with lower case src:

ag "Drupal\\\Tests\\\.*\\\Functional" core | grep namespace
ag "Drupal\\\Tests\\\.*\\\Functional" core | grep namespace | grep -v src
ag "Drupal\\\Tests\\\.*\\\Functional" core | grep namespace | grep -v tests

rtbc from me also.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 43ac93d and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed cf6909c on 8.2.x 
    Issue #2754541 by webflo, YesCT: Fix folder location in BrowserTestBase...

  • alexpott committed 43ac93d on 8.1.x 
    Issue #2754541 by webflo, YesCT: Fix folder location in BrowserTestBase...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.