We need to start covering existing javascript functionality within Views with test, see #2752931: [meta] Implement Javascript testing for Views and the Views UI.

This is about adding test coverage to the basic View creation Wizard.

Create some basic Views through the Views Wizard, and see if the Views specific javascript does the right things.

CommentFileSizeAuthor
#2 views_wizard_javascript-2753905-2.patch2.02 KBlendude

Comments

Lendude created an issue. See original summary.

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented
Status: Active » Needs review
StatusFileSize
new views_wizard_javascript-2753905-2.patch2.02 KB

First stab at some basic stuff.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community 
+++ b/core/modules/views_ui/tests/src/FunctionalJavascript/ViewsWizardTest.php
@@ -0,0 +1,61 @@
+ * @group views_ui
+ */
+class ViewsWizardTest extends JavascriptTestBase {
+
+  /**
+   * {@inheritdoc}
+   */
+  public static $modules = ['node', 'views', 'views_ui', 'block'];
+
+  /**
+   * {@inheritdoc}
+   */
+  protected function setUp() {
+    parent::setUp();
+
+    $admin_user = $this->drupalCreateUser([
+      'administer site configuration',
+      'administer views',
+    ]);
+    $this->drupalLogin($admin_user);
+  }
+

Should we open up a dedicated issue for a common testbase or just use it here?

lendude’s picture

lendude
Primary language Dutch
Location Amsterdam
commented

Created an issue for setting up a base class, makes it a bit clearer what needs to be done #2754171: Create a Views and ViewsUI FunctionalJavascriptTestBase class

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +DevDaysMilan

Committed 89ae2a0 and pushed to 8.1.x and 8.2.x. Thanks!

  • alexpott committed 1836688 on 8.2.x 
    Issue #2753905 by Lendude: Add javascript testing for the Views creation...

  • alexpott committed 89ae2a0 on 8.1.x 
    Issue #2753905 by Lendude: Add javascript testing for the Views creation...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.