Follow-up to #2752659: [META] Convert SimpleTest Tests to PHPUnit

Core is deprecating SimpleTest for Drupal 9 and converting all the tests #2735005: Convert all Simpletest web tests to BrowserTestBase (or UnitTestBase/KernelTestBase).

Convert ParagraphsAccessTest and ParagraphsExperimentalAccessTest to PHPUnit

CommentFileSizeAuthor
#15 2753877-15.patch5.79 KBLendude
#9 paragraphs-access_tests_conversion-2753877-9.patch4.23 KBjmuzz
#4 paragraphs-access_tests_conversion-2753877-4.patch11.57 KBjmuzz
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

GoZ created an issue. See original summary.

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku commented
Assigned: Unassigned » Peter Majmesku

I'm on it.

Peter Majmesku’s picture

Peter Majmesku
Location 🇩🇪Düsseldorf
CreditAttribution: Peter Majmesku commented
Assigned: Peter Majmesku » Unassigned

I've un-assigned the ticket from me, since I don't know when I will find time to work on this.

jmuzz’s picture

jmuzz CreditAttribution: jmuzz commented
Status: Active » Needs review
FileSize
paragraphs-access_tests_conversion-2753877-4.patch11.57 KB

I tried to change as little as possible. A couple things:

- The new system doesn't support adding multiple files to the form at once the same way so the files are posted in two steps.

- Mink tries to emulate a user browser so it doesn't operate on hidden fields like "height" and "weight." This version will create a real image of a black pixel so these values get set properly.

- Javascript for the new testing system is still a work in progress last I heard. The forms seem to work when posted without javascript though so I just changed some drupalPostAjaxForms to drupalPostForms.

Status: Needs review » Needs work

The last submitted patch, 4: paragraphs-access_tests_conversion-2753877-4.patch, failed testing.

The last submitted patch, 4: paragraphs-access_tests_conversion-2753877-4.patch, failed testing.

The last submitted patch, 4: paragraphs-access_tests_conversion-2753877-4.patch, failed testing.

GoZ’s picture

GoZ CreditAttribution: GoZ at Centarro commented

@jmuzz you should use git diff -M so patch rename file and show changes instead of deleted and create new one.

jmuzz’s picture

jmuzz CreditAttribution: jmuzz commented
Status: Needs work » Needs review
FileSize
paragraphs-access_tests_conversion-2753877-9.patch4.23 KB

Oh that's great I didn't know about that.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented
Status: Needs review » Needs work

We discussed that the BrowserTestBase is horrible slow and only want to convert an absolute minimum of tests that need a JS head.

I don't think we need it here.. Back to check, won't fix if agree.

jmuzz’s picture

jmuzz CreditAttribution: jmuzz commented

I'm not sure if you are saying you want to make it a unit/kernel test or you are thinking about just not converting the tests altogether since you are suggesting "won't fix".

If you want to keep using simpletest then browsertestbase isn't really needed for any tests.

The problem with that is that simpletest is getting deprecated by core so it won't be supported nearly as well and its support will depend on contrib module developers not wanting to make the conversion and working to keep it alive.

jmuzz’s picture

jmuzz CreditAttribution: jmuzz commented
Status: Needs work » Needs review

I'm setting it back so hopefully we can get some information about what exactly needs to happen to move this forward.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented

Miro mixed up BrowserTestBase and JavascriptTestBase above. BTB is not Javascript, it is more or less as fast as WebTestBase (possibly a bit slower, but not much).

I see that converting the two ajax calls to not use ajax is easy, wondering if that's because it is BTB. If so, then my JS argument from the other issue is kind of invalid and we might be able to convert everything to BTB. Which means I'm definitely +1 to doing it in a single issue. The changes are going to be very repetitive and it will be easier to review and test it at once.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
CreditAttribution: miro_dietiker at MD Systems GmbH commented

Ah yeah, my mind always falsely mixes "Browser" with Javascript - like a real JS aware browser... Some day i will get it...

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
FileSize
2753877-15.patch5.79 KB

First continuation of this, WIP

Edit: Uh ok, one failed locally, but I guess that was just a local system hiccup.

Lendude’s picture

Lendude
Primary language Dutch
Location Amsterdam
CreditAttribution: Lendude at ezCompany commented
Title: Convert ParagraphsAccessTest to PHPUnit » Convert ParagraphsAccessTest and ParagraphsExperimentalAccessTest to PHPUnit
Issue summary: View changes

  • Berdir committed 9bff577 on 8.x-1.x authored by Lendude 
    Issue #2753877 by jmuzz, Lendude: Convert ParagraphsAccessTest and...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.