function push_notifications_used_languages() {
  ...
  if (!empty($used_languages)) {
    $used_langauges = asort($used_languages);

Here "used_langauges" should be "used_languages."

CommentFileSizeAuthor
#5 push_notifications-typo_disallows_language_sort-2753799-5.patch1.28 KBjacob.embree
#3 push_notifications-typo_disallows_language_sort-2753799-3.patch492 bytesSumit Gawde

Comments

justaman created an issue. See original summary.

ashwinsh’s picture

ashwinsh
He/Him
Primary language English
Location Pune
commented

Hello justaman,

I have checked both 7.x-1.2 and 7.x-1.x-dev and it seems that there is not type mistake. Could you please recheck it from your end.

Thank you,

Sumit Gawde’s picture

Sumit Gawde commented
Status: Active » Needs review
StatusFileSize
new push_notifications-typo_disallows_language_sort-2753799-3.patch492 bytes

Here is a patch.

jacob.embree’s picture

jacob.embree commented
Version: 7.x-1.2 » 7.x-1.x-dev
Assigned: justaman » Unassigned
Status: Needs review » Needs work

Unassigning from justaman because I assume he's providing any patches.
Setting version to the development branch.
Needs work because the return value from asort() is a success indicator, not the sorted array. asort() modifies the array directly.

jacob.embree’s picture

jacob.embree commented
Issue summary: View changes
Status: Needs work » Needs review
StatusFileSize
new push_notifications-typo_disallows_language_sort-2753799-5.patch1.28 KB